Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 6007FC4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v2] rtw88: refine fw_crash debugfs to show non-zero while
 triggering
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20211001082301.4805-1-pkshih@realtek.com>
References: <20211001082301.4805-1-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <tony0620emma@gmail.com>, <linux-wireless@vger.kernel.org>,
        <kevin_yang@realtek.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-Id: <20211005052854.D8E27C4360D@smtp.codeaurora.org>
Date:   Tue,  5 Oct 2021 05:28:54 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
> 
> The usage of fw_crash debugfs is to write 1 to it to trigger fw crash
> simulation and to read from it to check the state. When zero is read,
> it is supposed to mean fw crash/restart process is done. Then, some
> test plans can be designed for crash/restart.
> e.g.
> step 1. trigger fw crash simulation
> step 2. poll the state until zero is read
> step 3. check connection by ping test
> 
> However, in certain connection cases, triggering fw crash simulation
> will take a while. If the state is queried too early before restart
> begins processing, it may mistakenly think restart process has been
> done. If some tests are started at this time, something unexpected
> might happen due to the follow-up restart process.
> 
> To avoid that, let fw_crash also show non-zero when a simulation
> is still triggering.
> 
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

6cd4b59ddb1a rtw88: refine fw_crash debugfs to show non-zero while triggering

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211001082301.4805-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches