Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org DBB9CC4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Arend van Spriel <aspriel@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: firmware: Treat EFI nvram ccode=XT the same as ccode=XV
References: <20211003160325.119696-1-hdegoede@redhat.com>
Date:   Tue, 05 Oct 2021 08:36:48 +0300
In-Reply-To: <20211003160325.119696-1-hdegoede@redhat.com> (Hans de Goede's
        message of "Sun, 3 Oct 2021 18:03:25 +0200")
Message-ID: <87fstgghhr.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hans de Goede <hdegoede@redhat.com> writes:

> In some cases the EFI-var stored nvram contains "ccode=ALL", "ccode=XV"
> or "ccode=XT", to specify "worldwide" compatible settings, but these
> ccode-s do not work properly. "ccode=ALL" causes channels 12 and 13 to
> not be available, "ccode=XV" / "ccode=XT" may cause all 5GHz channels
> to not be available.
>
> ccode="ALL" and ccode="XV" where already being replaced with ccode="X2"
> with a bit of special handling for nvram settings coming from an EFI
> variable. Extend this handling to also deal with nvram settings from
> EFI variables which contain "ccode=XT", which has similar issues to
> "ccode=XV".
>
> This fixes 5GHz wifi not working on the HP ElitePad 1000 G2.
>
> This was also tested on a Lenovo Thinkpad 8 tablet which also uses
> "ccode=XT" and this causes no adverse effects there.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

To me worldwide compatible settings mean that channels 12 and 13 should
be disabled, so I'm quite hesitant about this patch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches