Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 5 Oct 2021 17:08:05 +0100
From:   Daniel Golle <daniel@makrotopia.org>
To:     Felix Fietkau <nbd@nbd.name>
Cc:     linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org,
        devicetree@vger.kernel.org, Ryder Lee <ryder.lee@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/2] dt: bindings: net: mt76: add eeprom-data property
Message-ID: <YVx4ZaIZsfNQocT+@makrotopia.org>
References: <YSWdv7ZKz7SBtF+v@makrotopia.org>
 <de40bcd3-d730-4d6b-27d0-50492fe18404@nbd.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <de40bcd3-d730-4d6b-27d0-50492fe18404@nbd.name>
Precedence: bulk

On Fri, Sep 24, 2021 at 07:14:47PM +0200, Felix Fietkau wrote:
> 
> On 2021-08-25 03:33, Daniel Golle wrote:
> > EEPROM data for mt76 can be embedded into device-tree as an array.
> > 
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> >  .../devicetree/bindings/net/wireless/mediatek,mt76.yaml      | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > index 3e2c2e43175e5..1489d3c1cd6ec 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> > @@ -47,6 +47,11 @@ properties:
> >  
> >    ieee80211-freq-limit: true
> >  
> > +  mediatek,eeprom-data:
> > +    $ref: /schemas/types.yaml#/definitions/uint32-array
> Given that the driver patch simply uses memcpy on the data, shouldn't we
> use an uint8-array here?

When using the /incbin/('file.bin'); syntax the result is included as
what appears to be a uint32-array when decompiling again with dtc.