Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp1938540pxb; Thu, 7 Oct 2021 19:22:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWWkB71Bagtjsjq1YBfi6yXKCYP3BZa1OhYjf78wTQ+maJpYgTtfpTLLY/KgqcdTlrIYQB X-Received: by 2002:a63:ec45:: with SMTP id r5mr2488891pgj.440.1633659730587; Thu, 07 Oct 2021 19:22:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633659730; cv=none; d=google.com; s=arc-20160816; b=zVw69s9gN7vC4XymaP/oFG3RvZWT5a8UcCiqRvfQ4h3X1Nk4pM3Ar2fospIAe/XZKs F/Y6vGxaVK3ic4aCLP0kk/iCS+reFY4r+/OeJ8rLIzTcG6Mz6jvIdKPxBp5u9hDx50YM vzB0zknInpJM9fmZ0SJqeYjiWr+/D4rEAD0GaBorxD7TmRrYdSCWfFq+qDQr2Y8EYtNK e5Ooj/Xf8YmvJkO2cun43en+LyJ62Oww9LWZriWyI9cGtfC8yWuyizyIPnqN0ZlSvILS 8KdnJ4HYaCuHV6bkiwvR314gO9Rn/El0lUPOuBTEOrB4e+bMYG7EVUfrCrmwmgv+ile4 D2gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4+iA2jWt06Zj7Wf7mNNn1ZAYUuFTYUHAxtblldAFv6U=; b=XtWD4QYgtu/xIs7QrTT3V6AHkX8vG/zLIhGLRW3Wkfx765RbjIWbkMo8K5Apg7Yzz6 BirwbYOVha4ItOKgyvILHsreVRmFvNw3tkXEK8bZD9GZFaMMT7w8B+RugvAzyWJjqmD9 u6inQYPlaQRCVjFqkFAeA5dg0+qnOVUTdFA/nl2qsqvCUSL5oKYZPc/HaHKxrvWzrntJ /9/pDiNnifHGqCFkpAIzhkoj/FwigOEwk/o+R7CI+JIvkw6czTOxIin9jH5z0jZO7VFc gWGNZGiT3Xmh/bYuZGAQzTYRSSKh4pXicR/+Vv7a3OZVGm7g6/nvsyAGNridpM6zS8jw j67Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=EEuFNsE2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s5si1291717pgk.86.2021.10.07.19.21.52; Thu, 07 Oct 2021 19:22:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=EEuFNsE2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235472AbhJHCXZ (ORCPT + 76 others); Thu, 7 Oct 2021 22:23:25 -0400 Received: from mx3.wp.pl ([212.77.101.10]:49642 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233051AbhJHCXZ (ORCPT ); Thu, 7 Oct 2021 22:23:25 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Thu, 07 Oct 2021 22:23:24 EDT Received: (wp-smtpd smtp.wp.pl 29449 invoked from network); 8 Oct 2021 04:14:48 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1633659288; bh=4+iA2jWt06Zj7Wf7mNNn1ZAYUuFTYUHAxtblldAFv6U=; h=From:To:Cc:Subject; b=EEuFNsE2kS9t5ssacWgxkwcwiivkoloSjdhsPjt1dK96noh1LYbU75w1SFhfAAX1h IlQnzMt3pKTmtpEz/Oi0AFtnxNmqLkdY5TtmT7To+zRlei3NYPn9725uCeoRxxgErF Z6IQUKhAq5+7XggJE6Uhlm7w58GE37JYhxQhr5a4= Received: from unknown (HELO kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com) (kubakici@wp.pl@[163.114.132.5]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 8 Oct 2021 04:14:48 +0200 Date: Thu, 7 Oct 2021 19:14:42 -0700 From: Jakub Kicinski To: Colin King Cc: Kalle Valo , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: Remove redundant initialization of variable ret Message-ID: <20211007191442.2da691df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211007234153.31222-1-colin.king@canonical.com> References: <20211007234153.31222-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 97d23a12387b9de539baf411b446f3b8 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000003 [YVDm] Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 8 Oct 2021 00:41:53 +0100 Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read, > it is assigned later on with a different value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Acked-by: Jakub Kicinski