Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Ping-Ke Shih <pkshih@realtek.com>, kvalo@codeaurora.org
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v7 08/24] rtw89: implement mac80211 ops
In-Reply-To: <20211008035627.19463-9-pkshih@realtek.com>
References: <20211008035627.19463-1-pkshih@realtek.com>
 <20211008035627.19463-9-pkshih@realtek.com>
Date:   Fri, 08 Oct 2021 19:45:14 +0200
Message-ID: <87h7drl8b9.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> writes:

> To yield better TX performance, wake TX queue is implemented.

I went looking for this, and was happy to find it! :)

Do you also support airtime reporting and/or AQL? And if not, any plans
to do so?

One small nit below:

> +static void rtw89_ops_wake_tx_queue(struct ieee80211_hw *hw,
> +				    struct ieee80211_txq *txq)
> +{
> +	struct rtw89_dev *rtwdev = hw->priv;
> +
> +	ieee80211_schedule_txq(hw, txq);
> +	queue_work(rtwdev->txq_wq, &rtwdev->txq_work);

Why the call to ieee80211_schedule_txq()? mac80211 calls that before
calling wake_tx_queue() (through the schedule_and_wake_txq() helper), so
it seems a bit superfluous here?

-Toke