Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 50174C4360C
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Arend van Spriel <aspriel@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@infineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
        Wright Feng <wright.feng@infineon.com>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        brcm80211-dev-list.pdl@broadcom.com,
        SHA-cyfmac-dev-list@infineon.com
Subject: Re: [PATCH] brcmfmac: firmware: Treat EFI nvram ccode=XT the same as ccode=XV
References: <20211003160325.119696-1-hdegoede@redhat.com>
        <87fstgghhr.fsf@codeaurora.org>
        <43e39a93-fed1-acbb-517e-94cf0d6d739c@redhat.com>
        <CAJ65rDyNR+a-4=eY=MFXLgXueaTX7yro4bpEnKtOOEYiWCdcbg@mail.gmail.com>
Date:   Mon, 11 Oct 2021 09:08:27 +0300
In-Reply-To: <CAJ65rDyNR+a-4=eY=MFXLgXueaTX7yro4bpEnKtOOEYiWCdcbg@mail.gmail.com>
        (Arend van Spriel's message of "Tue, 5 Oct 2021 10:37:18 +0200")
Message-ID: <878rz05c10.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Arend van Spriel <aspriel@gmail.com> writes:

> On Tue, Oct 5, 2021 at 10:02 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Hi Kalle,
>>
>> On 10/5/21 7:36 AM, Kalle Valo wrote:
>> > Hans de Goede <hdegoede@redhat.com> writes:
>> >
>> >> In some cases the EFI-var stored nvram contains "ccode=ALL", "ccode=XV"
>> >> or "ccode=XT", to specify "worldwide" compatible settings, but these
>> >> ccode-s do not work properly. "ccode=ALL" causes channels 12 and 13 to
>> >> not be available, "ccode=XV" / "ccode=XT" may cause all 5GHz channels
>> >> to not be available.
>> >>
>> >> ccode="ALL" and ccode="XV" where already being replaced with ccode="X2"
>> >> with a bit of special handling for nvram settings coming from an EFI
>> >> variable. Extend this handling to also deal with nvram settings from
>> >> EFI variables which contain "ccode=XT", which has similar issues to
>> >> "ccode=XV".
>> >>
>> >> This fixes 5GHz wifi not working on the HP ElitePad 1000 G2.
>> >>
>> >> This was also tested on a Lenovo Thinkpad 8 tablet which also uses
>> >> "ccode=XT" and this causes no adverse effects there.
>> >>
>> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > To me worldwide compatible settings mean that channels 12 and 13 should
>> > be disabled, so I'm quite hesitant about this patch.
>>
>> The X2 setting puts channel 12 and 13 in passive / listen-only modes
>> and only starts using them if there is an AP on them.
>>
>> AFAIK this is the same with the XT/XV settings. The problem is that the XT
>> setting results in 5G not being available on some boards even though the
>> hw supports it.
>>
>> Also note that we already use the X2 setting for any EFI supplied nvram
>> files where ccode=ALL or ccode=XV, this just extends the handling we
>> already have to also patch ccode=XT.
>
> I am not overly excited about this approach that is already in use.
> AFAIK these worldwide codes are tailored for specific
> devices/customers based on their RF components. Using it as fallback
> for other devices in such a generic way could even result in exceeding
> regulatory limits. However, I do not have a better solution for this.
> I am surprised to learn there are nvram out there with ccode=ALL as
> that is for internal use only, but if these devices has SROM than the
> nvram value is ignored. Hopefully, that is the case although given the
> fact that changing it to X2 helps suggests otherwise :-(

What's the conclusion? Should I take this or drop it?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches