Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org AB4ABC4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH 1/2] b43legacy: fix a lower bounds test
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20211006073542.GD8404@kili>
References: <20211006073542.GD8404@kili>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
        kernel-janitors@vger.kernel.org
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163393258963.11913.9834603879232230405.kvalo@codeaurora.org>
Date:   Mon, 11 Oct 2021 06:09:53 +0000 (UTC)
Precedence: bulk

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The problem is that "channel" is an unsigned int, when it's less 5 the
> value of "channel - 5" is not a negative number as one would expect but
> is very high positive value instead.
> 
> This means that "start" becomes a very high positive value.  The result
> of that is that we never enter the "for (i = start; i <= end; i++) {"
> loop.  Instead of storing the result from b43legacy_radio_aci_detect()
> it just uses zero.
> 
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Michael Büsch <m@bues.ch>

2 patches applied to wireless-drivers-next.git, thanks.

c1c8380b0320 b43legacy: fix a lower bounds test
9b793db5fca4 b43: fix a lower bounds test

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211006073542.GD8404@kili/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches