Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1198118pxb; Mon, 11 Oct 2021 00:04:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSYi9rzJT9C6qjlj0aPVXc7hZxCL+jQ3qtug3zg5Z5JqVdGnAslT10BtamyWiBl6w9zILC X-Received: by 2002:a05:6402:1c85:: with SMTP id cy5mr14313100edb.281.1633935858812; Mon, 11 Oct 2021 00:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633935858; cv=none; d=google.com; s=arc-20160816; b=UZ7f8tQ+o3KAliPgCc85U2OrfQGrZhJBseyFB1SVDJw2ddPmspbgGs1CoGGztg4pQU 3WQGHWJhK+QKMvMCV0YbILAaFHqYeIUyJS0zzp+cEoZMcyWCK6QqBvZkOAQMfEDTdJfZ gKj3YAAhFMwoSP/K0vBXLh5dhjIXeSbSxwRBRnN6HAfrBQ4mblinrKyfmGsPmFYf0F2s 7VvZ3lXufSnBqg3Nkywx+OKm/0a8I5o3TTncrxROy9tifdfHmV8v8y0ni4jGpU4f16Yj wBwJn6KPclxgRC4H5b9XqbRmUnuGO2QeTQyDxcUwvcbr9VK4ftAZYP4v2RyrgIIJIlpS olew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=h7IfVo+dSWcnAR0NKGiUy+LkFKcRh55dCDpcuLc57fY=; b=Apg9s5AvNFB6PIu3+eWPz+vxjWA3l1cl4oN4YbnruKogO1lWFAzjctuFOc/x7SVVBR uxTFLCkcAN/CooEw3M41iBwnxgv/gi9keyaZBfijfrdUsnfK1dSuLa5amsM2XX0x8m8J l6CfpKcgrhqS9aq7BjmOPP1iNdSVmw8nT6Hb/V6AehUYqdqrbl6Em5xXjALGNKw5DzpG zI6kBv+XwoHsUExKH55DhK2wDkjm/GYsZ1BohLqeFid55tt7EcnfeUPd73F7cpe5ZzBQ O6CI+S+c0J6f8fUC+rOct5FfhiDnPYA4UgfZ6NWRupJyyTpHW/CfQljj50yYY+Z9+hVa 39Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=tr1bu33W; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jx12si10182326ejc.294.2021.10.11.00.04.00; Mon, 11 Oct 2021 00:04:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=tr1bu33W; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234116AbhJKG0Z (ORCPT + 76 others); Mon, 11 Oct 2021 02:26:25 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:53903 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234137AbhJKG0Y (ORCPT ); Mon, 11 Oct 2021 02:26:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633933465; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=h7IfVo+dSWcnAR0NKGiUy+LkFKcRh55dCDpcuLc57fY=; b=tr1bu33WTe/EEa5PJc+rmz/NKJMAQjTSZj8Mun3MwapBWxU9+16Z6DRZV0W2eG3g+PLn0ZSM W7W/LQ/v57RWyvhfYMujyGZSR4Qnj6ElKMOoqmEndjAKR32vncYsJDp80sjYLRzi4r0WEJ3P 4YQwtMUO0lizxJgyIpziGURYwQI= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 6163d889f3e5b80f1f0f56ea (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 Oct 2021 06:24:09 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4F401C43460; Mon, 11 Oct 2021 06:24:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5D369C4338F; Mon, 11 Oct 2021 06:24:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 5D369C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] ath11k: Remove redundant assignment to variable fw_size From: Kalle Valo In-Reply-To: <20211006105529.1011239-1-colin.king@canonical.com> References: <20211006105529.1011239-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , Jakub Kicinski , Anilkumar Kolli , Jouni Malinen , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163393344268.20318.10512441412282046693.kvalo@codeaurora.org> Date: Mon, 11 Oct 2021 06:24:09 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > Variable fw_size is being assigned a value that is never read and > being re-assigned a new value in the next statement. The assignment > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Fixes: 336e7b53c82f ("ath11k: clean up BDF download functions") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 4f50bdfb4e5f ath11k: Remove redundant assignment to variable fw_size -- https://patchwork.kernel.org/project/linux-wireless/patch/20211006105529.1011239-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches