Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 05/11] mt76: mt7915: debugfs hook to enable TXS for
 NO_SKB pkt-ids
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
References: <20210804134505.3208-1-greearb@candelatech.com>
 <20210804134505.3208-5-greearb@candelatech.com>
 <87mtpda079.fsf@tynnyri.adurom.net>
 <093b94ea-b6db-aca8-26c4-6981e57e8ff4@candelatech.com>
 <87ily352s4.fsf@codeaurora.org>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <0894595c-cea8-6ced-2082-9c7abc9f88d3@candelatech.com>
Date:   Mon, 11 Oct 2021 07:12:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <87ily352s4.fsf@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/11/21 2:28 AM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
> 
>> On 8/19/21 9:06 AM, Kalle Valo wrote:
>>> greearb@candelatech.com writes:
>>>
>>>> From: Ben Greear <greearb@candelatech.com>
>>>>
>>>> This lets user turn on/off this feature.  Enabling gives better
>>>> tx-rate related stats, but will cause extra driver and (maybe)
>>>> firmware work.  Not sure if it actually affects performance or
>>>> not.
>>>>
>>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>>
>>> This is grey area, debugfs is not really meant to be used for users
>>> enabling driver features.
>>>
>>
>> What method do you suggest?  Surely not trying to drive something down through
>> netlink for something this chipset specific?
> 
> I think a module parameter would be a good choise for enabling this kind
> of feature.
> 
> Of course the downside of a module parater is that when it's not
> possible to configure this per device, only per driver. Like discussed
> many times in the past, we would really need some kind more advanced
> module parameters which can be per device.

Enabling/disabling via debugfs is way more useful than a module parameter.
It is per-device and also changeable at run-time.  Maybe you want to enable
detailed stats for a bit of time for some reason, and then go back to lower
overhead approach.

You are asking for a worse technical solution than debugfs implementation.

For the per-device module parameters, I implemented something similar for
ath10k using a 'fwcfg' file that is loaded with device options sort of like
a board file.  That worked well enough for that sort of thing.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com