Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authenticated-By: 
From:   Pkshih <pkshih@realtek.com>
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver
Thread-Topic: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver
Thread-Index: AQHXlXz6iS5M0zbbfkSyaj358Nztiqu+mXDngAQPmeCAAYZwOYAEmYxwgAHbWe2ABEdl8A==
Date:   Tue, 12 Oct 2021 01:53:35 +0000
Message-ID: <d5b9ddecd1a24ed1a7e8c7c9f72d3528@realtek.com>
References: <20210820043538.12424-1-pkshih@realtek.com>
        <8735pkiu0t.fsf@codeaurora.org>
        <9b54e3c321a4414cbae62616d8a913f4@realtek.com>
        <877desggrm.fsf@codeaurora.org>
        <b59b709da12e4c938745eddd73efeec7@realtek.com>
 <87h7dq61qt.fsf@codeaurora.org>
In-Reply-To: <87h7dq61qt.fsf@codeaurora.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering
 rules found
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/10/11_=3F=3F_10:54:00?=
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36503.realtek.com.tw, 9
X-KSE-Attachment-Filter-Triggered-Rules: Clean
X-KSE-Attachment-Filter-Triggered-Filters: Clean
X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled
X-KSE-AntiSpam-Outbound-Interceptor-Info: scan successful
X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 10/12/2021 01:32:37
X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED
X-KSE-AntiSpam-Method: none
X-KSE-AntiSpam-Rate: 0
X-KSE-AntiSpam-Info: Lua profiles 166652 [Oct 11 2021]
X-KSE-AntiSpam-Info: Version: 5.9.20.0
X-KSE-AntiSpam-Info: Envelope from: pkshih@realtek.com
X-KSE-AntiSpam-Info: LuaCore: 463 463 5854868460de3f0d8e8c0a4df98aeb05fb764a09
X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to}
X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;realtek.com:7.1.1
X-KSE-AntiSpam-Info: Rate: 0
X-KSE-AntiSpam-Info: Status: not_detected
X-KSE-AntiSpam-Info: Method: none
X-KSE-AntiSpam-Info: Auth:dkim=none
X-KSE-Antiphishing-Info: Clean
X-KSE-Antiphishing-ScanningType: Heuristic
X-KSE-Antiphishing-Method: None
X-KSE-Antiphishing-Bases: 10/12/2021 01:35:00
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On
> Behalf Of Kalle Valo
> Sent: Saturday, October 9, 2021 4:28 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver
> 
> Pkshih <pkshih@realtek.com> writes:
> 
> >> -----Original Message-----
> >> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On
> >> Behalf Of Kalle Valo
> >> Sent: Tuesday, October 5, 2021 1:52 PM
> >> To: Pkshih <pkshih@realtek.com>
> >> Cc: linux-wireless@vger.kernel.org
> >> Subject: Re: [PATCH v6 00/24] rtw89: add Realtek 802.11ax driver
> >>
> >> Pkshih <pkshih@realtek.com> writes:
> >>
> >> >> The community has been testing this driver already, right?
> >> >
> >> > As Larry mentioned, end users use this driver. Since bugs found in v6,
> >> > we have fixed them and driver is under QA. I plan to have that fixes in v7
> >> > released this week.
> >> >
> >> > This version will also include fixes of your comments.
> >> > Does it work to you?
> >>
> >> Sounds good to me. I hope the changes in v7 will be small in size,
> >> bigger changes (especially new features) is better to do after the
> >> driver is applied to wireless-drivers-next.
> >>
> >
> > I have fixed this driver according to all of your comments, so I
> > don't reply the comments one by one. If this doesn't work to you,
> > please let me know.
> 
> That's good, no need to reply to every comment. But please do reply to
> the comments you did not agree on.
> 

The only one question is about __always_inline, and Arnd have guided me
how to do. (Thanks again)
And, I agree the other comments.

--
Ping-Ke