Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A24A3C4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     greearb@candelatech.com
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7915: add debugging for MCU command timeouts.
References: <20211011205406.23485-1-greearb@candelatech.com>
Date:   Tue, 12 Oct 2021 08:14:47 +0300
In-Reply-To: <20211011205406.23485-1-greearb@candelatech.com> (greearb's
        message of "Mon, 11 Oct 2021 13:54:06 -0700")
Message-ID: <878ryy25a0.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

greearb@candelatech.com writes:

> From: Ben Greear <greearb@candelatech.com>
>
> Print information about whether the message is the first timeout,
> and also print info if we manage to recover after a timeout.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> NOTE:  Not sure this is really something folks would want upstream, but
> maybe it helps someone else trying to debug this driver.

If the patch is not ready for upstream it's a good idea to mark it as
RFC, that way the maintainers can skip it automatically.

> +	if (mdev->first_failed_mcu_cmd) {
> +		dev_err(mdev->dev, "MCU: First success after failure: Message %08x (cid %lx ext_cid: %lx seq %d)\n",
> +			cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
> +			FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq);
> +		mdev->first_failed_mcu_cmd = 0;
> +	}
> +	else {
> +		// verbose debugging
> +		//dev_err(mdev->dev, "MCU: OK response to message %08x (cid %lx ext_cid: %lx seq %d)\n",
> +		//	cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
> +		//	FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq);
> +	}

No C++ comments and no commented out code, please.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches