Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3154469pxb; Tue, 12 Oct 2021 23:22:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDuEfwP8fW/HauhvIh/Up51W5iSwPrqtazfp7Vz/5IrFGMNn6QkPEAUEFih85+ykKkAp1G X-Received: by 2002:a17:90a:d801:: with SMTP id a1mr11173850pjv.109.1634106155545; Tue, 12 Oct 2021 23:22:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634106155; cv=none; d=google.com; s=arc-20160816; b=Scb/mJF8jQGTjPVPA1kQoqUdmtH4fBoho1h2Ax6KLBfhrTeL/AFu9wbOWRJyZ66M6P 8QHL7a0NYtPRk9beNDvpIRmgFEjQJ7ByTrviMAPA53Db3azifFM+uTgf5AgGM7NyUA0M MVcDwRbDw/Zoxwash3TR+9m4alYNvbcNuRljV4L0MvT12pU6JOy+FOewjDtbeBou9rSU 2/ZMu7uJ32LkjEwJxQEvSGbLBgr+tnxpvfDQGedoOiyGo4x5dSawOgFEnjfQQRhJ7OvX iWSI2QLpPQAZsDvFOIGHWnq2lKbaTXEO5cSvRFpHRwibGxp7n1HrV8xuU0AmEit5QJZH A24A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=V2OPHckyobktWQtuAc5EG+B1zGNtGj5+Sq6WwRx60r0=; b=cO5cm0rm/SfVipDk4iqfHoo0Oc9MXCSZnMspH0nc+u+FImc1L/UgwQVsboGV+KFDNy UD+0AazEsZaC9MnL97ts1ytnckFrJApx0thplTvQxNzbDcgPNtmTQuoljcQB0XMzGKYT g+oayqMRuGeNNYdILouTQ1UEvgKbyQpPFAuX9Fb7kZLVPXI/ncRT/EGBZ8Oi+YTAlL1J EW+xTnU0iHlWJqh2g01sukwUFyoPIV16ui3RV2MCNCHAEcb34VmumZ4uFNHZqB+d2Aad UwIc4PazihjleVNzHK2+ldKyLabVcgyXKP0QvbcUr5I3j7+MdCEFvmLf2+MfwzPcnYon I3NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=RLLdE4ZV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si16020442pfl.185.2021.10.12.23.22.26; Tue, 12 Oct 2021 23:22:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=RLLdE4ZV; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237909AbhJMGXo (ORCPT + 63 others); Wed, 13 Oct 2021 02:23:44 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:60387 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229777AbhJMGXo (ORCPT ); Wed, 13 Oct 2021 02:23:44 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634106101; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=V2OPHckyobktWQtuAc5EG+B1zGNtGj5+Sq6WwRx60r0=; b=RLLdE4ZV8XPni5YseOz9zhmaMPFGT1L6UO0ZGrcCucYq2XOE7ZjujZYdEAQHAOGyy4bJm5Fk LZBYViEIs1cPGB9Z1NJGjgvmeA9chKkzNEb7jkpqY8aFXoHcVvXGyzaoh4t5Ogxb2njALdT8 ihtb92aEJkXgl8Y5BHAGC4RUJ08= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 61667adf22fe3a98e51f787d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 13 Oct 2021 06:21:19 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 453CFC43460; Wed, 13 Oct 2021 06:21:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84B05C4338F; Wed, 13 Oct 2021 06:21:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 84B05C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mt7601u: Remove redundant initialization of variable ret From: Kalle Valo In-Reply-To: <20211007234153.31222-1-colin.king@canonical.com> References: <20211007234153.31222-1-colin.king@canonical.com> To: Colin King Cc: Jakub Kicinski , "David S . Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163410607355.12983.9788871417859723671.kvalo@codeaurora.org> Date: Wed, 13 Oct 2021 06:21:18 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read, > it is assigned later on with a different value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Jakub Kicinski Patch applied to wireless-drivers-next.git, thanks. 3e4beec5e679 mt7601u: Remove redundant initialization of variable ret -- https://patchwork.kernel.org/project/linux-wireless/patch/20211007234153.31222-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches