Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 4A19EC4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 2/7] iwlwifi: mei: add the driver to allow cooperation with CSME
References: <20210811105541.43426-1-emmanuel.grumbach@intel.com>
        <20210811105541.43426-2-emmanuel.grumbach@intel.com>
Date:   Mon, 18 Oct 2021 13:56:41 +0300
In-Reply-To: <20210811105541.43426-2-emmanuel.grumbach@intel.com> (Emmanuel
        Grumbach's message of "Wed, 11 Aug 2021 13:55:36 +0300")
Message-ID: <87tuhevbx2.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:

> CSME in two words
> -----------------
> CSME stands for Converged Security and Management Engine. It is
> a CPU on the chipset and runs a dedicated firmware.
> AMT (Active Management Technology) is one of the applications
> that run on that CPU. AMT allows to control the platform remotely.
> Here is a partial list of the use cases:
> * View the screen of the plaform, with keyboard and mouse (KVM)
> * Attach a remote IDE device
> * Have a serial console to the device
> * Query the state of the platform
> * Reset / shut down / boot the platform

[...]

> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -92,6 +92,23 @@ config IWLWIFI_BCAST_FILTERING
>  	  If unsure, don't enable this option, as some programs might
>  	  expect incoming broadcasts for their normal operations.
>  
> +config IWLMEI
> +	tristate "Intel Management Engine communication over WLAN"
> +	depends on INTEL_MEI
> +	depends on PM
> +	depends on IWLMVM
> +	help
> +	  Enables the iwlmei kernel module. This allows to communicate with
> +	  the Intel Management Engine over Wifi. This is supported starting
> +	  from Tiger Lake platforms and has been tested on 9260 devices only.
> +	  Enabling this option on a platform that has a different device and
> +	  has Wireless enabled on AMT can prevent WiFi from working correctly.

I don't understand the last sentence, please elaborate. Are you saying
that enabling CONFIG_IWLMEI will break wi-fi in some cases?

> +	  For more information see
> +	  <https://software.intel.com/en-us/manageability/>
> +
> +	  If unsure, say N.

IMHO the help text still contains too much Intel jargon to be really
understandable by everyone. I think the commit log pretty well
summarises what this is all about:

  "CSME stands for Converged Security and Management Engine. It is a CPU
   on the chipset and runs a dedicated firmware. AMT (Active Management
   Technology) is one of the applications that run on that CPU. AMT
   allows to control the platform remotely."

Somehow including that information to the Kconfig help text would be
very helpful to everyone.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches