Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org E0B4EC4360D
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 4/7] iwlwifi: integrate with iwlmei
References: <20210811105541.43426-1-emmanuel.grumbach@intel.com>
        <20210811105541.43426-4-emmanuel.grumbach@intel.com>
Date:   Mon, 18 Oct 2021 14:03:46 +0300
In-Reply-To: <20210811105541.43426-4-emmanuel.grumbach@intel.com> (Emmanuel
        Grumbach's message of "Wed, 11 Aug 2021 13:55:38 +0300")
Message-ID: <87pms2vbl9.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Emmanuel Grumbach <emmanuel.grumbach@intel.com> writes:

> iwlmei needs to know about the follwing events:
>
> * Association
> * De-association
> * Country Code change
> * SW Rfkill change
> * SAR table changes
>
> iwlmei can take the device away from us, so report the new
> rfkill type when this happens.
> Advertise the required data from the CSME firmware to the
> usersapce: mostly, the AP that the CSME firmware is currently
> associated to in case there is an active link protection
> session.
> Generate the HOST_ASSOC / HOST_DISSASSOC messages.
>
> Don't support WPA1 (non-RSNA) for now.
> Don't support shared wep either.
> We can then determine the AUTH parameter by checking the AKM.
> Feed the cipher from the key installation.
>
> SW Rfkill will be implemented later when cfg80211 will
> allow us to read the SW Rfkill state.
>
> Co-Developed-by: Ayala Beker <ayala.beker@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

[...]

> @@ -1932,6 +1952,17 @@ void iwl_mvm_enter_ctkill(struct iwl_mvm *mvm);
>  int iwl_mvm_send_temp_report_ths_cmd(struct iwl_mvm *mvm);
>  int iwl_mvm_ctdp_command(struct iwl_mvm *mvm, u32 op, u32 budget);
>  
> +#ifdef CONFIG_IWLMVM_VENDOR_CMDS
> +
> +/* vendor commands */
> +void iwl_mvm_vendor_cmds_register(struct iwl_mvm *mvm);
> +
> +#else // IWLMVM_VENDOR_CMDS
> +
> +static inline void iwl_mvm_vendor_cmds_register(struct iwl_mvm *mvm) {}
> +
> +#endif // IWLMVM_VENDOR_CMDS

Shouldn't this be in patch 6?

And no C++ style comments, please.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches