Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210811105541.43426-1-emmanuel.grumbach@intel.com>
 <20210811105541.43426-2-emmanuel.grumbach@intel.com> <87y26qvg05.fsf@codeaurora.org>
 <CANUX_P0CxotNk1omOELgFWWDTzJXMmzSBPKg6k1f_kbBookWuQ@mail.gmail.com>
In-Reply-To: <CANUX_P0CxotNk1omOELgFWWDTzJXMmzSBPKg6k1f_kbBookWuQ@mail.gmail.com>
From:   Emmanuel Grumbach <egrumbach@gmail.com>
Date:   Mon, 18 Oct 2021 14:17:04 +0300
Message-ID: <CANUX_P25aQuih=ZnAsVchiWqQdO7G1aHyReZ2yxUAc29GH=bog@mail.gmail.com>
Subject: Re: [PATCH v6 2/7] iwlwifi: mei: add the driver to allow cooperation
 with CSME
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> > > +
> > > +/*
> > > + * Do not export the device table because this module is loaded by
> > > + * iwlwifi's dependency.
> > > + */
> > > +
> > > +static struct mei_cl_driver iwl_mei_cl_driver = {
> > > +     .id_table = iwl_mei_tbl,
> > > +     .name = KBUILD_MODNAME,
> > > +     .probe = iwl_mei_probe,
> > > +     .remove = iwl_mei_remove,
> > > +};
> > > +
> > > +module_mei_cl_driver(iwl_mei_cl_driver);
> >
> > Not sure iwl_mei_cl_driver can be const or not, most probably not. But
> > please do check.
>
> I will.

I can't :(