Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp157325pxb; Mon, 18 Oct 2021 23:24:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtlViTYWKx2tjkd4c3tYVJOan+vyUhZkG0AR8DaxvttzQVGyQOR5Fzd9vHXmOcuXUgJdnc X-Received: by 2002:a50:d80d:: with SMTP id o13mr50355923edj.204.1634624698083; Mon, 18 Oct 2021 23:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634624698; cv=none; d=google.com; s=arc-20160816; b=Ics6tYRRPQUg4DVGLJPPSUdqZoGmF0WBO1VXYBWwk32qugPl1dXI+TzpX1aQ1X4mxT bCyTaPFPeaX+p+UPZgcZ5/Pg7PmJQ08WhjM/y5EHwvAgzdbc8pNOHSdXNj7bVd7A6zvJ celBKjPxOcZaXG4lj2xiFq4dczr1BhuUvrccuGJrbiMBXwwmgEyvkE+P7JNRZOPB5LxF /DW1HDC43Sqx5oxuTTrYH8X24vDvuWvxz7sqaKftBJ0LmpWEctHufJRYXg5QOvra8G3G iftjvs4L/n3MzjATANq0IpNyRcI+CgqTs+zNAVyTAusSuXA5AA/j/njh2VYGn2a5FO/C 1jKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature :dkim-signature:date; bh=JmonJHMmw4GJweFmaKQYoWKH7A+91AtuAa0M2axQW1Q=; b=TNXX5xMh3JkaHIBNjO1t1Zho7F2VfxSsD+AGJgZ18tCXbgv3+AbZR5QYOGYIaijrKp v7d5EKj15iMfxEgTf9O5s/Ot+7pzHsBGE7LbOXEQpcnWXlUvPT/nOe5Hbr/cay5a+wve 2hWiPuIr3QeNpnjKnNuSKh48pxwn3yOFf9wkK7VOL52uy4rGy9IPfI99VHfj7j+oc9T4 3g4IVYKPVZWZZPMkdhjZwHZFERfNtGwYQA4wlwfibWgflAu7OUDoaV1XzJAzJj01kjB4 MvZCr1WwRlL3APc0zR9eEArx+5i7obKD99g3xZueknCj5Eh8Y+sdbwzYIwgf6u5W3Fpf Buag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=r90lG1FL; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nc38si34771291ejc.708.2021.10.18.23.24.38; Mon, 18 Oct 2021 23:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=r90lG1FL; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234165AbhJSG02 (ORCPT + 64 others); Tue, 19 Oct 2021 02:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233786AbhJSG01 (ORCPT ); Tue, 19 Oct 2021 02:26:27 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 667D4C06161C for ; Mon, 18 Oct 2021 23:24:15 -0700 (PDT) Date: Tue, 19 Oct 2021 08:24:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1634624652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JmonJHMmw4GJweFmaKQYoWKH7A+91AtuAa0M2axQW1Q=; b=r90lG1FLnXPzmAgpW9dQeuAtPFIMsb2nIKdboT28Cpvfjg684ekb7Y/reqBg8ec+3kMeQs Cl9z+X71DE20XkCunlZp0LXsaUl9yfYYw5Q+FFix8LQw9067SKuKf/M+UGhl5+Q2CjTlqF l3sjdUO6ZazFNaHX6tbkbOUQFjCQlgszfHlI8vxOWPrFmxfZNr6sTypuRCLeyEfL4FuFCn kA/XS+ZoRG8utNET4/d6esHiGBR+p/mUxwpUZH6IlZO3pXiEEv0YMFRRjwFitdZTluF7mg hN95VGb1ypYj7U2Y6xII8YyMMAQhqWZv2iWbcab+JnKY0lxhjqx63VN2jZjqJA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1634624652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JmonJHMmw4GJweFmaKQYoWKH7A+91AtuAa0M2axQW1Q=; b=kdTmGPp63//GoO47P6UIRWYwbu0WH2zG2U6PhbqVYM+zbgP5TVkSlRsBFv+ZAbp3cira/5 LqzcyIIzp4UrVADQ== From: Sebastian Andrzej Siewior To: Jakub Kicinski Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH 08/15] wireless: cisco: use eth_hw_addr_set() Message-ID: <20211019062410.ivoiqon45j6tbe5z@linutronix.de> References: <20211018235021.1279697-1-kuba@kernel.org> <20211018235021.1279697-9-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211018235021.1279697-9-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-10-18 16:50:14 [-0700], Jakub Kicinski wrote: > Commit 406f42fa0d3c ("net-next: When a bond have a massive amount > of VLANs...") introduced a rbtree for faster Ethernet address look > up. To maintain netdev->dev_addr in this tree we need to make all > the writes to it got through appropriate helpers. > > Use dev_addr_set() to match the existing logic. > setup_card() is always passed netdev->dev_addr, so pass the netdev > pointer instead and assign the address using a helper there. > > Signed-off-by: Jakub Kicinski Reviewed-by: Sebastian Andrzej Siewior Sebastian