Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1265531pxb; Wed, 20 Oct 2021 01:23:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIqs2Q+udZjjlxBKza7pg/iU/nJ/BncheGx22Av+3KWBmrglOBNFw/hN0QZBjLP6y4QZXX X-Received: by 2002:a17:906:2816:: with SMTP id r22mr44779291ejc.158.1634718209960; Wed, 20 Oct 2021 01:23:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634718209; cv=none; d=google.com; s=arc-20160816; b=uTdesDKl4gvNX5B3YQrdA6xTBr98sCFoZuJW1jIN6l6eQn+w8V89iGjA805hwfxsGJ hBgOc+/1TdAAuJeP5CtHMWeQ1MfuWdxy62eBasEOdtPOnCaQ9B8nv9RZ2ZqDilaluZq1 VI3cPdNG4l7V4Z+ybH4czb4ZgBQjvaCZg5bwz8ABa7X7pFm84iqm1WiafQuSIAyP67HC U6V9q57TGWECv5Iy7X9u5agKdYQpgh53Jk9ElKrI9Pgw1VmcfsofgpIL+buTt/iPDFV8 IDxbtCMqhdH7KlJHJXG4SfJNasRUNwjLVo1AHw7mvzWylX0RhP8mGV+8lcnhlnoGStiJ 4IsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=9a/lBUPLEX9oekw9Cx3rqnVMr3Nf9ETTTIIpjPQQ3tA=; b=dIQlapbyXt+mva+hYoJiS2A0VePv2GUh73Ukv+gZHGI35v8sDhjo/9+jAaA8Ox66yi axQAOSY/NzBxBgPViCQ0J3VLTUqex9b0WZtVX/PNtEXAXY7NFs9DlIOYB7CHQbO/0/+y hPY9yNgkuloG/UfhEgI0JmLNQXYnrWQ5RO0ON3hgPwXWh18L6KRllXpvv/Ll/OqIT3o6 +0w2IROA58fh2QWybaE0F+WOrOc1GY/BEFa8rGG8B8U/QBcwS4tb2KT8SmffGn93H5X8 WQzqmg2XYDu0ByAEFI3loT/CSkE2b1kuk41FO4JpmZHzkGJHOoKrct8J0/2+u8kRAa5b kG5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="w0Qq9/Ph"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si3033330edm.438.2021.10.20.01.23.14; Wed, 20 Oct 2021 01:23:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="w0Qq9/Ph"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbhJTIXb (ORCPT + 64 others); Wed, 20 Oct 2021 04:23:31 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:52903 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhJTIXa (ORCPT ); Wed, 20 Oct 2021 04:23:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1634718076; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=9a/lBUPLEX9oekw9Cx3rqnVMr3Nf9ETTTIIpjPQQ3tA=; b=w0Qq9/PhasKq9asd/+Ldy1HWEJB1YEfpitkG12FMhWIA5Ts6BmfRoFAEZxJmEEhBVHhZzCro Bs3DSO5sk/V4FtZ1sIBUF1Um4ig43xi+dC/I/PASZBdgXTWnnXaYqTim2pZxs0MEoQH7Ar19 kU7WC0hbIO2tICohS/Ye0HnaLYM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 616fd17afd91319f0f02447d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 20 Oct 2021 08:21:14 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B92F5C43460; Wed, 20 Oct 2021 08:21:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 933B4C4338F; Wed, 20 Oct 2021 08:21:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 933B4C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Emmanuel Grumbach Cc: Emmanuel Grumbach , linux-wireless Subject: Re: [PATCH v6 2/7] iwlwifi: mei: add the driver to allow cooperation with CSME References: <20210811105541.43426-1-emmanuel.grumbach@intel.com> <20210811105541.43426-2-emmanuel.grumbach@intel.com> <87y26qvg05.fsf@codeaurora.org> Date: Wed, 20 Oct 2021 11:21:09 +0300 In-Reply-To: (Emmanuel Grumbach's message of "Mon, 18 Oct 2021 14:17:04 +0300") Message-ID: <87pms0f6oa.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Emmanuel Grumbach writes: >> > > + >> > > +/* >> > > + * Do not export the device table because this module is loaded by >> > > + * iwlwifi's dependency. >> > > + */ >> > > + >> > > +static struct mei_cl_driver iwl_mei_cl_driver = { >> > > + .id_table = iwl_mei_tbl, >> > > + .name = KBUILD_MODNAME, >> > > + .probe = iwl_mei_probe, >> > > + .remove = iwl_mei_remove, >> > > +}; >> > > + >> > > +module_mei_cl_driver(iwl_mei_cl_driver); >> > >> > Not sure iwl_mei_cl_driver can be const or not, most probably not. But >> > please do check. >> >> I will. > > I can't :( Ok, thanks for checking. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches