Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2088960pxb; Fri, 22 Oct 2021 13:43:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyK8o7u0oRDBV+QPFdTb1zcDN6HdHYmEb6C2eGzZxE1L/ivSoj/V+PeEob8Lyade5hCCP0 X-Received: by 2002:a05:6402:438f:: with SMTP id o15mr3048194edc.53.1634935434506; Fri, 22 Oct 2021 13:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634935434; cv=none; d=google.com; s=arc-20160816; b=wivKZZTOYTjK1qJED4DBkI70sRA11UgxOb0pZRMaGy9X74+fX1jiw76O2NGf4NRsSc X0qDvR+ywhhft/9tBt2t975GuIfw/QuskBEYYPdwqr0i2FyEQzxqXicCHWEqci5virvQ jnKy+nzWXMWPw16G6UO/LJappXrUt86DzsxlgJk6Orw4hlCwZHr35Rx59DQ79GlhwiU5 XMOG4Kc+P+kYMX/+eUUIjLjS7dXpgw25Bppr6VPCjzHOZJIa0sJiG4n7Xk0keGBi4Ysd ScJHir1NAdEFcELgAfN9HDTStKbBiM4UgpwFZ7iQyo3T7j46InYTGzKss+6nt9XfZen6 kRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mnQWHW6uCnfpT9WFZ7pKq066Q8jmFGMEj4UJ6pnKOwk=; b=bMAn0TPzzKd2A2OldciZupyvNbZYA4u0jrYxrc+iAt5nKlkVFuzfPeJQD6qcVdAq6e MjGgXyxbjyVfyKGhguYpX87n4pUL5eOi4DKrsIyttFU8hS/YsnFlAV6QTL1kg0YUXwnH WJCfIIn6//howYeERmi2qj3CCBhXmJAXCVCkeg599F1QGwCxsI6UfkUy0M8SmoO98z5J 95fzKzksD7chPwhUr747k75BMT5xv1PLgS5vtEAoq4HGAlLUcGzTZSn5qLsXEDx6xT0O OEYDq9QBJXcSId6vTwnolW/wjOen+d3+v9g2stngbgwhup+E0u1MzUfUm1Egt/UZCdV/ SW1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=itkPhCty; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs43si16004831ejc.379.2021.10.22.13.43.34; Fri, 22 Oct 2021 13:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=itkPhCty; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233939AbhJVUpt (ORCPT + 64 others); Fri, 22 Oct 2021 16:45:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:39164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232750AbhJVUpt (ORCPT ); Fri, 22 Oct 2021 16:45:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0301C61040; Fri, 22 Oct 2021 20:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634935411; bh=QRjAV4o4+c8NfwPqd5WLPxIN0sMUZnkUhgzIjbrx0a4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=itkPhCtyunDKctXAy8m4YJbI9dZSlLgaLhH5MH5KxfVrVQsS1i+BKxb/mrt05j3da C6THCecgrvL0JGtyUZKmt3ENO/roDksF5YsKhhiJajXXkyi/WAvsh4Gv3Y+q5q0vNQ XRqpAQ2dEaP1YaaxPfYwjZVhul0nbbwYRzSR8k/hR2+MTaJEg6eNUoMpgfCxLOjGiY u+2pJYWdIk9HALuoFFjHw2I0n0MKRT3kMWRN+etuuAe7DyxUo7848MTIjogZ7F/2NK 45d4Yk1Xcxbym/n55ok/zWDaMhDVdtB+viHYj53d4XdCaeD2YnXkvV6Y0SBqdUtOo3 bpFSdFWkcADfg== Date: Fri, 22 Oct 2021 13:43:30 -0700 From: Jakub Kicinski To: "Martinez, Ricardo" Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com Subject: Re: [PATCH 00/14] net: wwan: t7xx: PCIe driver for MediaTek M.2 modem Message-ID: <20211022134330.25ac88af@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20211021202738.729-1-ricardo.martinez@linux.intel.com> <20211021152317.3de4d226@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 22 Oct 2021 13:20:38 -0700 Martinez, Ricardo wrote: > On 10/21/2021 3:23 PM, Jakub Kicinski wrote: > > On Thu, 21 Oct 2021 13:27:24 -0700 Ricardo Martinez wrote: > >> t7xx is the PCIe host device driver for Intel 5G 5000 M.2 solution > >> which is based on MediaTek's T700 modem to provide WWAN connectivity. > > > > It needs to build cleanly with W=1, and have no kdoc warnings > > (scripts/kernel-doc -none). > > > It builds cleanly with W=1, I test with 'make W=1 -C . M=drivers/net/wwan/t7xx'. > Regarding kernel-doc, there's an enum that does need a documentation update. Fetch the latest net-next/master, rebase and try again. Throw in sparse checking for good measure (C=1).