Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e373d617-4884-08d6-1aae-4fbfa7b01767@linux.intel.com>
Date:   Fri, 22 Oct 2021 14:03:17 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 00/14] net: wwan: t7xx: PCIe driver for MediaTek M.2 modem
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
        davem@davemloft.net, johannes@sipsolutions.net,
        ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
        m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com,
        linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com,
        haijun.liu@mediatek.com
References: <20211021202738.729-1-ricardo.martinez@linux.intel.com>
 <20211021152317.3de4d226@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <cdb9e908-b87f-cda9-5b5d-bd1eb250ba10@linux.intel.com>
 <20211022134330.25ac88af@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   "Martinez, Ricardo" <ricardo.martinez@linux.intel.com>
In-Reply-To: <20211022134330.25ac88af@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/22/2021 1:43 PM, Jakub Kicinski wrote:
> On Fri, 22 Oct 2021 13:20:38 -0700 Martinez, Ricardo wrote:
>> On 10/21/2021 3:23 PM, Jakub Kicinski wrote:
>>> On Thu, 21 Oct 2021 13:27:24 -0700 Ricardo Martinez wrote:
>>>> t7xx is the PCIe host device driver for Intel 5G 5000 M.2 solution
>>>> which is based on MediaTek's T700 modem to provide WWAN connectivity.
>>>
>>> It needs to build cleanly with W=1, and have no kdoc warnings
>>> (scripts/kernel-doc -none).
>>>    
>> It builds cleanly with W=1, I test with 'make W=1 -C . M=drivers/net/wwan/t7xx'.
>> Regarding kernel-doc, there's an enum that does need a documentation update.
> 
> Fetch the latest net-next/master, rebase and try again.
> 
> Throw in sparse checking for good measure (C=1).
> 
I see that now, thanks.