Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <03845fc8-17a4-22b2-52fa-4fb013432a7a@linaro.org>
Date:   Mon, 25 Oct 2021 09:40:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.1
Subject: Re: [PATCH] wcn36xx: Fix packet drop on resume
Content-Language: en-US
To:     Loic Poulain <loic.poulain@linaro.org>, kvalo@codeaurora.org
Cc:     wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org
References: <1635150496-19290-1-git-send-email-loic.poulain@linaro.org>
From:   Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <1635150496-19290-1-git-send-email-loic.poulain@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/10/2021 09:28, Loic Poulain wrote:
> If the system is resumed because of an incoming packet, the wcn36xx RX
> interrupts is fired before actual resuming of the wireless/mac80211
> stack, causing any received packets to be simply dropped. E.g. a ping
> request causes a system resume, but is dropped and so never forwarded
> to the IP stack.
> 
> This change fixes that, disabling DMA interrupts on suspend to no pass
> packets until mac80211 is resumed and ready to handle them.
> 
> Note that it's not incompatible with RX irq wake.
> 
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> ---
>   drivers/net/wireless/ath/wcn36xx/main.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index a42eae6..a650b9e 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -1137,6 +1137,13 @@ static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow)
>   			goto out;
>   		ret = wcn36xx_smd_wlan_host_suspend_ind(wcn);
>   	}
> +
> +	/* Disable IRQ, we don't want to handle any packet before mac80211 is
> +	 * resumed and ready to receive packets.
> +	 */
> +	disable_irq(wcn->tx_irq);
> +	disable_irq(wcn->rx_irq);
> +
>   out:
>   	mutex_unlock(&wcn->conf_mutex);
>   	return ret;
> @@ -1159,6 +1166,10 @@ static int wcn36xx_resume(struct ieee80211_hw *hw)
>   		wcn36xx_smd_ipv6_ns_offload(wcn, vif, false);
>   		wcn36xx_smd_arp_offload(wcn, vif, false);
>   	}
> +
> +	enable_irq(wcn->tx_irq);
> +	enable_irq(wcn->rx_irq);
> +
>   	mutex_unlock(&wcn->conf_mutex);
>   
>   	return 0;
> 

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>