Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp709013pxb; Wed, 27 Oct 2021 10:49:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXpgDI1GZA80iwo6M+7WTh6KPlkrojQVfZXFoUJhrxAm45MzGYLUq3qLk15PgLPAKqdKq+ X-Received: by 2002:a17:90b:3144:: with SMTP id ip4mr7467472pjb.58.1635356983115; Wed, 27 Oct 2021 10:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635356983; cv=none; d=google.com; s=arc-20160816; b=R+3PUkNglKXXLUYg/qZ1Z/wij7Mz4NzIWYZ76ptEU3H787Hek3Kn/kYHD0puG0fJZW Rtv/WeQDEMXmGnQ4I8UhlwFk8eAeM8b9Ci2qOWOuJVr/35MbSpCyCORqgqhoCuZHKrzh 1LBTkAiTuWMDGUWucBLJvq1S9cmJ/TEhVPQ6QiHCKGCA9bqB7edUou41bAXUTXlrs5dT majJm7/HpJfvnfFxC5XD680RGMBnsiDrCh6X/Tt8ARcADxt1WaKOpp+tqFZjQ2Nz8knm ZOgx9a24SzoT5nXKyHtm5N1dE0vtoAbSKKmL6DKB4y6poVUh4mZOcBck2UmzpPqqXhPq loww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=fXIGabjlwVjwSyXbgJxYwqoqXCDDr0GCdHz+P5TjQcU=; b=mjcWD1Uio/z9sP7NQLpfdeug3LMJCMh8aFmAAhp5reh7qo5Hs0OkL3mrwHtCiXG2Ho VBG46Mmcxo5S4sfqv8mBpo7baphxGdOZu1iv7E68gKKRgCUsifjhX6m0dlsgmpQs+rvP 7t1m8aHLAsdzJJSTyYrYh1ti7koLUdFIG7X+OL/mKI7jz13qXyn3+egCO3q0zbYeCg64 djtnTjzAUMuDnlx1NY+sFxavbklVa5sh/9FYImMiE7pnh0D303VOH9LCjiGDyQuWqGVy Sdc/fdzlFkM2Xs3BA6ZdaIRWbUHSnXpphF6h6Kcc7zt4B+odr8PR24hzWNmwZRBjbVma 7Xtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o13si751769pgq.582.2021.10.27.10.49.34; Wed, 27 Oct 2021 10:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240188AbhJ0HBL (ORCPT + 67 others); Wed, 27 Oct 2021 03:01:11 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:58640 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbhJ0HBL (ORCPT ); Wed, 27 Oct 2021 03:01:11 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R541e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=cuibixuan@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0Utr.qNe_1635317920; Received: from VM20210331-25.tbsite.net(mailfrom:cuibixuan@linux.alibaba.com fp:SMTPD_---0Utr.qNe_1635317920) by smtp.aliyun-inc.com(127.0.0.1); Wed, 27 Oct 2021 14:58:44 +0800 From: Bixuan Cui To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kvalo@codeaurora.org, luciano.coelho@intel.com, davem@davemloft.net, kuba@kernel.org, gregory.greenman@intel.com, weiyongjun1@huawei.com Subject: [PATCH -next] iwlwifi: mvm: rfi: use kmemdup() to replace kzalloc + memcpy Date: Wed, 27 Oct 2021 14:58:40 +0800 Message-Id: <1635317920-84725-1-git-send-email-cuibixuan@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Fix memdup.cocci warning: ./drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING opportunity for kmemdup Signed-off-by: Bixuan Cui --- drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c index 4434421..1954b4c 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rfi.c @@ -107,12 +107,10 @@ struct iwl_rfi_freq_table_resp_cmd *iwl_rfi_get_freq_table(struct iwl_mvm *mvm) if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) != resp_size)) return ERR_PTR(-EIO); - resp = kzalloc(resp_size, GFP_KERNEL); + resp = kmemdup(cmd.resp_pkt->data, resp_size, GFP_KERNEL); if (!resp) return ERR_PTR(-ENOMEM); - memcpy(resp, cmd.resp_pkt->data, resp_size); - iwl_free_resp(&cmd); return resp; } -- 1.8.3.1