Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org EA1DCC43460
From:   Kalle Valo <kvalo@codeaurora.org>
To:     mpubbise@codeaurora.org
Cc:     Carl Huang <cjhuang@codeaurora.org>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org,
        cjhuang=codeaurora.org@codeaurora.org
Subject: Re: [PATCH] ath11k: enable power save in station mode
References: <20211011190625.4463-1-cjhuang@codeaurora.org>
        <f4457c0027a70d996eb5930a334a9832@codeaurora.org>
Date:   Thu, 28 Oct 2021 15:19:30 +0300
In-Reply-To: <f4457c0027a70d996eb5930a334a9832@codeaurora.org> (mpubbise's
        message of "Thu, 28 Oct 2021 10:53:34 +0530")
Message-ID: <87wnlx4a0d.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

mpubbise@codeaurora.org writes:

> On 2021-10-12 00:36, Carl Huang wrote:
>> Enable power save in station mode.
>>
>> Run "iw dev wls1 set power_save off",  check there is no NULL Data
>> frame
>> from sniffer. Run "iw dev wls1 set power_save on", check there is NULL
>> Data frame from sniffer.
>>
>> Tested-on: QCA6390 hw2.0 PCI
>> WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>>
>> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>

[...]

>> +int ath11k_wmi_set_psmode(struct ath11k *ar, u32 vdev_id,
>> +			  enum wmi_sta_ps_mode psmode)
>> +{
>> +	struct ath11k_pdev_wmi *wmi = ar->wmi;
>> +	struct wmi_sta_powersave_mode_cmd *cmd;
>> +	struct sk_buff *skb;
>> +	int ret;
>> +
>> +	skb = ath11k_wmi_alloc_skb(wmi->wmi_ab, sizeof(*cmd));
>> +	if (!skb)
>> +		return -ENOMEM;
>> +
>> +	cmd = (struct wmi_sta_powersave_mode_cmd *)skb->data;
>> +	cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG,
>> +				     WMI_TAG_STA_POWERSAVE_MODE_CMD) |
>> +			  FIELD_PREP(WMI_TLV_LEN, sizeof(*cmd) - TLV_HDR_SIZE);
>> +
>> +	cmd->vdev_id = vdev_id;
>> +	cmd->sta_ps_mode = psmode;
>> +
>> +	ath11k_dbg(ar->ab, ATH11K_DBG_WMI,
>> +		   "WMI set sta ps vdev_id %d ps %d\n",
>> +		   vdev_id, psmode);
>> +
>> +	ret = ath11k_wmi_cmd_send(wmi, skb, WMI_STA_POWERSAVE_MODE_CMDID);
>> +	if (ret) {
>> +		ath11k_warn(ar->ab, "failed to send WMI_STA_POWERSAVE_PARAM_CMDID");
>> +		dev_kfree_skb(skb);
>> +	}
>> +
>> +	return ret;
>> +}
>
> An API which does this is already present in ATH11K, you may have to
> take a look at ath11k_wmi_pdev_set_ps_mode() ?

Good catch, I'll fix this in v2.

And please do trim your replies, quotes over 200 lines long make it hard
to read.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches