Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4150642pxb; Tue, 2 Nov 2021 05:08:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4TxcZnzDjkjlyoYP2wMnMLV0VdOtO66cg9dMXNWITs0XIhZj+XbW8HmLmuKu9VKOsz+nW X-Received: by 2002:a17:907:160b:: with SMTP id hb11mr26985854ejc.336.1635854880188; Tue, 02 Nov 2021 05:08:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635854880; cv=none; d=google.com; s=arc-20160816; b=PaUeo7EH9hYKB1TVBdGJYrEgryBUmH/T7JSOMubFUjDoD4NRYKa1ZSBzenaUp2vmF2 YbEfPkk4ZvfJo3otEoNNimRnou2sD0jnij0vMjZZEjtHYDu6yycvTBqlGAOng+EjaNLc AxRqSgIu+6/ejkqx2/wY1KN/kC4fMKlYDn+yv+qGMQXAM22BZrgV7xQ3ckAeWfKls0ah hx3/N2wrpwhLg1Lb1lrcXfzWffTfnWax031a0QyvwdgdOpe9msSRn1iZmE7LHxUyKdrv 78WzdkEBNkDc686gdaIuXdYBRGh9pCD5FGGV1xfqWHiMFuL71p1G+miHk/MjL7AwABEO ssIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=h86VFtteEYl1f49xP1kVJB7134MIOfx/y5uzcAuQtDM=; b=Pzd7FYHswuO1GFpMuh/uvI7bRtK1om42ME9vigyZq754xdiTfG3tsWYkuPZMOK7XTl 77m6jKIUlnQa29zLkRySYYBCwxxeZ++VupX1UOiVX3Avw7hNKM+0O1htXw/O6EcUtZCz UJKb1YdHJquAPr9c8g+o8kdqqsKK1MTg5UG5cLuresSIbUC/8V0n2jCAG6oe6OWNQ4jO LUlzaSsYFRukbCh/zLO9MEVofgN5Q/1dpXZx/MjosLcXiraEojsonXXez5sROsiFkZTA TVlVP6jk5uag+Z+y85Epjm3r56AbaBA3N6sKqnjOoIOo226kwt07IjLqQpdc1h2PfOZt Efvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=Y1rI2R33; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si4887552ejo.694.2021.11.02.05.07.36; Tue, 02 Nov 2021 05:08:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=Y1rI2R33; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhKBMGZ (ORCPT + 66 others); Tue, 2 Nov 2021 08:06:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbhKBMGX (ORCPT ); Tue, 2 Nov 2021 08:06:23 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B748BC061714 for ; Tue, 2 Nov 2021 05:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=h86VFtteEYl1f49xP1kVJB7134MIOfx/y5uzcAuQtDM=; t=1635854628; x=1637064228; b=Y1rI2R33dAVVM9VMRTFMaotwUNuTd3RHsMuDB2pV/IK5o+A TKbdwvW1y41ABqGWx/hcZ/o3iG5IZ5/5HtxInQv4uCW3/IlDjGtOFYIONEmVXrZnFzfJ9rWNGj5LA 6vUd/CtY2GSilp3U01PbHtfBhy6imvmdSk/Da9VunfLRIbtb+HJ05F86FSTKmS4zCUt91Er7WAc07 pPLNn0HANTgI2ZlJv4PmO4hHMUygEWM9Y18Q+A5f2nM8UPYfhyXmgJfdNeuOJWNzR2t6I1k2fJQkA pPFg493ATXhmBZtHi0onO0XT/V1Jw5iszi9zRx8QhzLiOq+ctLA2T+fkhB0+1a1A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1mhsW2-009zp3-HQ; Tue, 02 Nov 2021 13:03:46 +0100 Message-ID: <4e39709c536e3b3c533a55f0bd4a536c49de8b34.camel@sipsolutions.net> Subject: Re: [PATCH] nl80211: fix radio statistics in survey dump From: Johannes Berg To: Sven Eckelmann , linux-wireless@vger.kernel.org Cc: Jan Fuchs Date: Tue, 02 Nov 2021 13:03:45 +0100 In-Reply-To: <2007334.cWPf2AUjKI@ripper> References: <20211029092539.2851b4799386.If9736d4575ee79420cbec1bd930181e1d53c7317@changeid> <2494935.OLRZgKR7aK@ripper> <2007334.cWPf2AUjKI@ripper> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2021-11-02 at 12:12 +0100, Sven Eckelmann wrote: > > Sorry, wanted to write more about it last week but forgot about it. If I > basically filter out the upper 32 bit in mvm->radio_stats.on_time_rf then it > didn't look that bad on a AX210. It seems like the upper bits is sometimes > 0x00000001 for unknown reasons. Like it would be some kind of flag which > should indicate some kind of change/event. So maybe the firmware team could > check what this means. Well, I checked, and it *is* just a u64 value. However, I suspect it sometimes underflows when powersave time is accounted into it, or something? johannes