Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4463834pxb; Sat, 6 Nov 2021 14:36:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWTYPE04j+UrYiv+bY8edixPRtC7CJJ9hkeL7lQtVj38UUO1qTihyqKUufjTTfSyCZDBuX X-Received: by 2002:a17:907:a414:: with SMTP id sg20mr48085382ejc.183.1636234563159; Sat, 06 Nov 2021 14:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1636234563; cv=none; d=google.com; s=arc-20160816; b=ZjSa5E3wiFdD5WanU2MJBfnXbkq/eVVuAHAD0euKuyk4ldR3mNp2k0nCoHw+Y5OZQQ UqlmJBhRj8yjBQ/NWN5ZgyAqpsZQUSHM1GWLcSKFsl/GtXUplqOjPKJ1FjmfNqDtdzsQ 1VfDYVC18UOJjiPLYHc1+c7wwebEr41He9MJpqt8WVHIc0NUKug5tlUmrrFle568mth7 OOmE/tTJAhCDgO6FO8LNyi+tkbnCT+lYcxSORBjm93mExlu0kx40RinRlAGUO6Jga5aS JaRvo0VecINzkTlOER4oe4Hxd68RrwIMSXJmpxc+2gSrdTHmgJp+YJXbccFHBKro+tId gwZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=p2XfxNRZgR4DiadXacP1AebZVGAP3mlK1UDvz8JbFrc=; b=XI5DIFYxfbwuIAAWxj3/7fX55IyBxxpmU/Pkvsl8bUGW77GGZzUcL3oTIBZI1hP9cW tAFpbjz+ew4rZENdWGdPldHXNVdszjK7WEWbzRkDFi9nHvzxBh1n0E3F/Sz5JTUeDdDe JLM0ApBkLHAveM+z26ZGa/GuP3TDXQJBTwkXYXA/dGgDeieRI8qB5dr6TdIHXYHhhKOp qJZBAO6ynY7VTUfmu6Cmeqa1mIT7ckK0GsnVqVr1nY5XJUTaAa68QitzppKDie6UHep1 ckTFua1fbgctoVJY3Z4nM8WAImCyxv6viABEaEDGqL45HA+NgVP417F+3EqcO90Sm5Lq DfBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZNVMlILc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si29008749edc.529.2021.11.06.14.35.48; Sat, 06 Nov 2021 14:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZNVMlILc; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233126AbhKFSCt (ORCPT + 67 others); Sat, 6 Nov 2021 14:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231979AbhKFSCr (ORCPT ); Sat, 6 Nov 2021 14:02:47 -0400 Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A577C061570; Sat, 6 Nov 2021 11:00:06 -0700 (PDT) Received: by mail-ua1-x92d.google.com with SMTP id v3so23257329uam.10; Sat, 06 Nov 2021 11:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p2XfxNRZgR4DiadXacP1AebZVGAP3mlK1UDvz8JbFrc=; b=ZNVMlILcAi1dKpydgkz1JPgGumaHBhEq9YGnQ5TbrCfU3eH/NOknskdSrvpjxbxWPZ nuB6s/IuUngRVFdOrHddFOFu62JLo2EnmdXn/ixzsacTesiwInH5PPB6gM9l98gCAlh2 zr6syMNAiKxUUOQPsNEP5bnxVoy1rcuIOlHO2jh6GNfIshZF/wpjbyYWfewSG0lN0Nsl woF4BRSkgqpiQnDib3GgOSU4GI/VVdtjBneOYjlrlPjA00ZPq2SXF7dykPW/MmoFWXTA ncwLeMNES51zNMn30BI/BL7ZPcV5S+xWopxnPhhSbc3CP0mZIffUWyEIfUq8Mv5KI+CJ Zluw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p2XfxNRZgR4DiadXacP1AebZVGAP3mlK1UDvz8JbFrc=; b=eg3qABL84uUXhYHVY88DX6U4rDiyadB62A4Nuc7KmuQgpvmvv0/rdPzm1HWiI+CYsk vvHnJ6RSY2jEcv1Ddit6OFFZy5bnLB9+5pVG98foNfVM391eGtACUfaagXU1zk06qVCS iQL/xCTDel1lvGUac07abO756Vcf4pu4+G+46RWGOwHXzV20NNfu5BVr1/+NA8/4xGT8 uNIwtHtNg8TV8FkFkOWlXaguvNGlhOOMZy3qkuHdgvX72G7eT4+GuwvlJxHgM/28ynfI /2/4H55DwHroozqTSXPcstjY1zxgb27CV1cO8qwWYj4OFUX0W/Sr3j2zp9sCna7CA+z9 EcSQ== X-Gm-Message-State: AOAM532Kh8ezhM97FLzwx7R2vClO0ymXXzQy0FAC3iHKt59v33fyQ66x Z5y3LeHIHvJwHCQnjLVcWgrVwvj7CoXTt5G7SvQ= X-Received: by 2002:ab0:780c:: with SMTP id x12mr72342855uaq.45.1636221605274; Sat, 06 Nov 2021 11:00:05 -0700 (PDT) MIME-Version: 1.0 References: <20211101035635.26999-1-ricardo.martinez@linux.intel.com> <20211101035635.26999-2-ricardo.martinez@linux.intel.com> In-Reply-To: <20211101035635.26999-2-ricardo.martinez@linux.intel.com> From: Sergey Ryazanov Date: Sat, 6 Nov 2021 21:01:08 +0300 Message-ID: Subject: Re: [PATCH v2 01/14] net: wwan: Add default MTU size To: Ricardo Martinez Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Jakub Kicinski , David Miller , Johannes Berg , Loic Poulain , M Chetan Kumar , chandrashekar.devegowda@intel.com, Intel Corporation , chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, amir.hanania@intel.com, Andy Shevchenko , dinesh.sharma@intel.com, eliot.lee@intel.com, mika.westerberg@linux.intel.com, moises.veleta@intel.com, pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com, Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com, suresh.nagaraj@intel.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Nov 1, 2021 at 6:57 AM Ricardo Martinez wrote: > Add a default MTU size definition that new WWAN drivers can refer to. [skipped] > +/* > + * Default WWAN interface MTU value > + */ > +#define WWAN_DEFAULT_MTU 1500 Why do you need another one macro for the 1500 bytes default MTU? Consider using ETH_DATA_LEN macro. -- Sergey