Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp494215pxh; Tue, 9 Nov 2021 14:09:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJywQEJRPJ05mgUdBnHp0Za3mQeCibD1Jxsh3AmPnW758plyQgJ2suMwGUXrwhdwUbdwj0yK X-Received: by 2002:a92:6e06:: with SMTP id j6mr1607665ilc.98.1636495786301; Tue, 09 Nov 2021 14:09:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636495786; cv=none; d=google.com; s=arc-20160816; b=S5fpQdo2nQnp4O0ufCsHAfThN2R0i/9BVEFONY60HPMQPkiA0uluT5/HPDIyLDa41y BXQ7DRDljTwQNnYRcWUM84uwDQWaMmDdcA962p75sB1Dw4n7Aon+Sm7B5NnxIu3FaXpQ jQNzEjd2BBWIdvPcHN6uVn65ObXFDBDbZ7tc3h4psrxwQ4pXP7i+fTlWRTi64+mwJFvE RBDUdoWMcRfrlF2Le4aLh4hwfvcAm8sQHaktiFZvePzxaZrxld4ZugnPPaUrqVnybz2B r4nZfeB7Odpns3WVGvOpA0g7PCWaIC7kwTjn2JT8+yQkqi6ssgH1caTHZNzbYqUm+LRx UW2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x8vezP+ySAQMzU4aH5GB9K9Xh+JMJ6//MlNYqk14zok=; b=gzPAWW35lQ/xo1owNBCJlUx60Wok89Rza0fePrESjcheyljg5hDoCiPYtnXhXuFjU0 8ViC2L/it6xhXSuyL03I2MNF11qkhyKXOGXTr9dvdGCJrtJXBLwDgJp8AlGWzZATz50x TCzH6M2AHFr0jAqoss5FvATLcAj6p3FWX891kl/pvTgk5LrB5mQ/wFk+mIVc411jC64E ao89T1R2d1HUVYEEFlLuDiNM79RHX+sJbkdiXmuZ3w3lEzsGtYnjAXNDeCI8CpiWing9 hw43gzO72WDK0kL/f0eV+B/95pWU6gJREh26m5VcmU0fwLLM/4lLGysrx5C/7DP8MmVV W1xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=k+P4M5Fg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si6260475ilu.121.2021.11.09.14.09.36; Tue, 09 Nov 2021 14:09:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=k+P4M5Fg; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237681AbhKIMK0 (ORCPT + 68 others); Tue, 9 Nov 2021 07:10:26 -0500 Received: from mx4.wp.pl ([212.77.101.12]:4971 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236479AbhKIMKZ (ORCPT ); Tue, 9 Nov 2021 07:10:25 -0500 Received: (wp-smtpd smtp.wp.pl 9402 invoked from network); 9 Nov 2021 13:07:37 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1636459657; bh=x8vezP+ySAQMzU4aH5GB9K9Xh+JMJ6//MlNYqk14zok=; h=From:To:Cc:Subject; b=k+P4M5FgvLpAcMCfITZmyobD4N5nuaymyVw2Fa3w7bNV2kfg6ZlzGLyokZ38Q1z67 mmN3OgarorLXdHDDEVTUdu56haV9lyaRttndZyqvAKuOqZd4rkqzabk0+aHcGDuOzh 1IIvg+rI+VxEsWpgbSidKyHX2rZ9KlmMbqZsrPtI= Received: from 89-64-85-14.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.85.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 9 Nov 2021 13:07:37 +0100 Date: Tue, 9 Nov 2021 13:07:37 +0100 From: Stanislaw Gruszka To: Thorsten Leemhuis Cc: Stanislaw Gruszka , linux-wireless@vger.kernel.org, Helmut Schaa , regressions@lists.linux.dev, Kalle Valo , Exuvo Subject: Re: rt2x00 regression Message-ID: <20211109120737.GA120005@wp.pl> References: <20191203075736.GA701@redhat.com> <87czop5j33.fsf@tynnyri.adurom.net> <6366d9bd-9752-dbc2-8970-442bdc6e8eea@leemhuis.info> <7d353dd2-2ffb-6d5e-9983-f983c8b4f6da@leemhuis.info> <20211109073127.GA109212@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211109073127.GA109212@wp.pl> X-WP-MailID: 1d59ce342643a1460894678b87309333 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [ocO0] Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Nov 09, 2021 at 08:32:07AM +0100, Stanislaw Gruszka wrote: > On Mon, Nov 08, 2021 at 07:00:20PM +0100, Thorsten Leemhuis wrote: > > Sending this again, but this time also to Stanislaw's email address > > currently found in MAINTAINERS. > > > > Stanislaw, can you help with this regression? > > Yes. > > I'll check on mail archives what is the status and what can be done. Ok, so what I can see here https://lore.kernel.org/linux-wireless/20211109073127.GA109212@wp.pl/T/#m6a677995c1afaf6b9b1ff19de9566f304089d3ac is that this problem happen only on firmware load, so I think we can use below patch as fix. Anton, please test it. Thanks Stanislaw diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c index e4473a551241..57c947dad036 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c @@ -30,7 +30,8 @@ static bool rt2x00usb_check_usb_error(struct rt2x00_dev *rt2x00dev, int status) else rt2x00dev->num_proto_errs = 0; - if (rt2x00dev->num_proto_errs > 3) + if (rt2x00dev->num_proto_errs > 3 && + !test_bit(DEVICE_STATE_STARTED, &rt2x00dev->flags)) return true; return false;