Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp489702pxh; Wed, 10 Nov 2021 05:06:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzU5U2aupSUMXuaCwZHAqo6W3wq4j6yJ9EuSN8aQEMSKszGIVZmtVE1izqUzClGV2R6cUI2 X-Received: by 2002:a17:906:3b18:: with SMTP id g24mr10900298ejf.27.1636549601327; Wed, 10 Nov 2021 05:06:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636549601; cv=none; d=google.com; s=arc-20160816; b=mVWCMRWimVb6z2aY/5yV8RNcDAd+acUVMabu7QL+qc46gBVZee8MREUTRugt7+tkQS 9CEdmQC0cAR+i5x9CDLaPDQu7Se66eS/XAqsmJxJJXRGWyLtmQE01PKER41TusIXjNNA 7ulh4rsrNxYtDUtqDSgckuXzeD66aDsdd0Pd6rqCnsPcW5kuX8LKtSf7eTkOTDbt4OrM AEl7Vt58DEYYUdp4XEkZmWgm//AGVPxBCxtUVBWbKhsNEydfkuX8HI+tOgr8r/teW6q/ 0NcbMX0MBeUzYhdN4L1wLPNBWMZliNP+xAQ7G+2AAnHRoMpIMtgEIY1urT7XX0kmkHaq ds3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:message-id; bh=DN5gWQMYn/MHYvoIMbp/odA8b4rLFHRsqcO80SvB/6w=; b=e05ZfL0weuGdjp3X+VM37jGx6CXR7CsqpfYmxk0IkTMYoTtscX/40jaKjy85r7ix7i HnFMA4xWNO8+Li40l/GLFT2V6OlekMIzrikB22x93EIPkTPNpB0G2JX12Zs245Y8GUGT naCYuBmx2J9emL83bOhAM9r2fk3St92JtZs6eJJyHGSGHXC5iAnuycScstEAGP205Aay pEMMjcrfeAcLGhQHCvrp3qXw0k+UL4Ar1OnZyAP48VQsBbO/lUeYxjg+DSADctuPvWOl 1ZKjIXTQ9do0oZoqUgdkdTKlNj/MXpZLezJumjAwHnTIj6N//QGClGcAtBMwln2FgvpE Es3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz24si17054660ejb.285.2021.11.10.05.06.24; Wed, 10 Nov 2021 05:06:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbhKJNIF (ORCPT + 68 others); Wed, 10 Nov 2021 08:08:05 -0500 Received: from paleale.coelho.fi ([176.9.41.70]:41356 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231998AbhKJNIE (ORCPT ); Wed, 10 Nov 2021 08:08:04 -0500 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[192.168.100.150]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mknHv-000ogV-2K; Wed, 10 Nov 2021 15:05:16 +0200 Message-ID: <1e1d3a7ee2abe2612a0120024a483590d050b3bf.camel@coelho.fi> From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Wed, 10 Nov 2021 15:05:13 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.0-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH v2] iwlwifi: mvm: retry init flow if failed Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2021-11-10 at 15:01 +0200, Luca Coelho wrote: > From: Mordechay Goodstein > > In some very rare cases the init flow may fail. In many cases, this is > recoverable, so we can retry. Implement a loop to retry two more times > after the first attempt failed. > > This can happen in two different situations, namely during probe and > during mac80211 start. For the first case, a simple loop is enough. > For the second case, we need to add a flag to prevent mac80211 from > trying to restart it as well, leaving full control with the driver. > > Cc: > Signed-off-by: Mordechay Goodstein > Signed-off-by: Luca Coelho > --- > In v2: fixed a missing brace. Kalle, sorry, I had a rebase damage in the previous version. Fixed in v2. I marked v1 as superseded and assigned v2 to you. -- Cheers, Luca.