Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2b21bfa5-4b18-d615-b6ab-09ad97d73fe4@linux.intel.com>
Date:   Tue, 11 Jan 2022 20:55:58 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH net-next v3 01/12] net: wwan: t7xx: Add control DMA
 interface
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Netdev <netdev@vger.kernel.org>, linux-wireless@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
        ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
        m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com,
        linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com,
        haijun.liu@mediatek.com, amir.hanania@intel.com,
        andriy.shevchenko@linux.intel.com, dinesh.sharma@intel.com,
        eliot.lee@intel.com, mika.westerberg@linux.intel.com,
        moises.veleta@intel.com, pierre-louis.bossart@intel.com,
        muralidharan.sethuraman@intel.com, Soumya.Prakash.Mishra@intel.com,
        sreehari.kancharla@intel.com
References: <20211207024711.2765-1-ricardo.martinez@linux.intel.com>
 <20211207024711.2765-2-ricardo.martinez@linux.intel.com>
 <a6325ef-e06e-c236-9d23-42fdb8b62747@linux.intel.com>
From:   "Martinez, Ricardo" <ricardo.martinez@linux.intel.com>
In-Reply-To: <a6325ef-e06e-c236-9d23-42fdb8b62747@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 12/16/2021 3:08 AM, Ilpo Järvinen wrote:
> On Mon, 6 Dec 2021, Ricardo Martinez wrote:
>
...
>> +static struct cldma_request *t7xx_cldma_ring_step_forward(struct cldma_ring *ring,
>> +							  struct cldma_request *req)
>> +{
>> +	if (req->entry.next == &ring->gpd_ring)
>> +		return list_first_entry(&ring->gpd_ring, struct cldma_request, entry);
>> +
>> +	return list_next_entry(req, entry);
>> +}
>> +
>> +static struct cldma_request *t7xx_cldma_ring_step_backward(struct cldma_ring *ring,
>> +							   struct cldma_request *req)
>> +{
>> +	if (req->entry.prev == &ring->gpd_ring)
>> +		return list_last_entry(&ring->gpd_ring, struct cldma_request, entry);
>> +
>> +	return list_prev_entry(req, entry);
>> +}
> Wouldn't these two seems generic enough to warrant adding something like
> list_next/prev_entry_circular(...) to list.h?

Agree, in the upcoming version I'm planning to include something like 
this to list.h as suggested:

#define list_next_entry_circular(pos, ptr, member) \
     ((pos)->member.next == (ptr) ? \
     list_first_entry(ptr, typeof(*(pos)), member) : \
     list_next_entry(pos, member))