Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 12 Jan 2022 18:20:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     "Martinez, Ricardo" <ricardo.martinez@linux.intel.com>,
        Netdev <netdev@vger.kernel.org>, linux-wireless@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net,
        ryazanov.s.a@gmail.com, loic.poulain@linaro.org,
        m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com,
        linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com,
        haijun.liu@mediatek.com, amir.hanania@intel.com,
        dinesh.sharma@intel.com, eliot.lee@intel.com,
        mika.westerberg@linux.intel.com, moises.veleta@intel.com,
        pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com,
        Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com
Subject: Re: [PATCH net-next v3 01/12] net: wwan: t7xx: Add control DMA
 interface
Message-ID: <Yd7/se+LD1c1wiBA@smile.fi.intel.com>
References: <20211207024711.2765-1-ricardo.martinez@linux.intel.com>
 <20211207024711.2765-2-ricardo.martinez@linux.intel.com>
 <a6325ef-e06e-c236-9d23-42fdb8b62747@linux.intel.com>
 <2b21bfa5-4b18-d615-b6ab-09ad97d73fe4@linux.intel.com>
 <Yd6+GjPLP2qCCEfv@smile.fi.intel.com>
 <b0cb18b-dc7b-9241-b21a-850d055d86@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b0cb18b-dc7b-9241-b21a-850d055d86@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Jan 12, 2022 at 04:24:52PM +0200, Ilpo J?rvinen wrote:
> On Wed, 12 Jan 2022, Andy Shevchenko wrote:
> > On Tue, Jan 11, 2022 at 08:55:58PM -0800, Martinez, Ricardo wrote:
> > > On 12/16/2021 3:08 AM, Ilpo J?rvinen wrote:
> > > > On Mon, 6 Dec 2021, Ricardo Martinez wrote:
> > 
> > > > > +	if (req->entry.next == &ring->gpd_ring)
> > > > > +		return list_first_entry(&ring->gpd_ring, struct cldma_request, entry);
> > > > > +
> > > > > +	return list_next_entry(req, entry);
> > 
> > ...
> > 
> > > > > +	if (req->entry.prev == &ring->gpd_ring)
> > > > > +		return list_last_entry(&ring->gpd_ring, struct cldma_request, entry);
> > > > > +
> > > > > +	return list_prev_entry(req, entry);
> > 
> > ...
> > 
> > > > Wouldn't these two seems generic enough to warrant adding something like
> > > > list_next/prev_entry_circular(...) to list.h?
> > > 
> > > Agree, in the upcoming version I'm planning to include something like this
> > > to list.h as suggested:
> > 
> > I think you mean for next and prev, i.o.w. two helpers, correct?
> > 
> > > #define list_next_entry_circular(pos, ptr, member) \
> > 
> > > ?? ?((pos)->member.next == (ptr) ? \
> > 
> > I believe this is list_entry_is_head().
> 
> It takes .next so it's not the same as list_entry_is_head() and 
> list_entry_is_last() doesn't exist.

But we have list_last_entry(). So, what about

list_last_entry() == pos ? first : next;

and counterpart

list_first_entry() == pos ? last : prev;

?

> > > ?? ?list_first_entry(ptr, typeof(*(pos)), member) : \
> > > ?? ?list_next_entry(pos, member))


-- 
With Best Regards,
Andy Shevchenko