Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp1466092pxb; Wed, 12 Jan 2022 15:43:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8dqb6X0K9C4jdAPLLpA77TbM5sdQ2YT7UgqTJcEt1yRdRVEW+aRmFG7YdQY6tnO+zVfa1 X-Received: by 2002:a17:902:da89:b0:149:304b:fd4c with SMTP id j9-20020a170902da8900b00149304bfd4cmr1856751plx.72.1642031030407; Wed, 12 Jan 2022 15:43:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1642031030; cv=none; d=google.com; s=arc-20160816; b=W2fX9jP2KSJ09u3D1hTXh7CzZ1mjdZHIOX3OAFXblUXhC+U61r3RiwCNNVfG/kVEGG X4Mgme3tqndzr9HHYb2IumC/vjNa9/SM18P/TzEfqS7Kk1dN7tn88Eoz6ogcWULN2fvg Qy2NKswSQ+4sBouR7H36JhGh4nLTzaTGf00RNq+U1mGixB4W17Uif8icxhLFBOmUe4nL ZEeOyjWrjUYAYeCUN4MPBbcBZLEeMoLHuK+dibPgE8/+/qsjSoiTb+935qgHhZ7l0Gc2 +WJeq280qRljM7Ky1gNJmzKpTT74MIL/1f7zo9smIRp1vWK25mYU1UwNbmzKQSGttjFm 3gbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=6rVv0ra3DNA0nHvw6wsb83XFwtI+TBowKe5LZ9Bd6xY=; b=dPINCMXp/YI9gIpO1fl6HMv+efJgVd3rmKsKHICmHH6MPXbRK3B/5e2d+eiBinkSye bLViYcDBG2PGW8kbz1CFSq8BLH10+/3pIkQImy7+QJ/aKk4FVzL343deMfApBHj2lLfy xrpj/ghhCHs9abnFdF+IuO/XdCI17aoel+I3FhtbVyaSq5LZCbFrypjLr3jWwWGN+1aX es079yA21jb5qulAW2dqtscPaqx4TJi/oox3ktFE1xueY6N58XpHyWHUTqJfoL6Momnn 6SfSoRnS78Y9ph78XetbEDVp5lSHIe5VleZ30OkzgKA/9aDkkciZGrRrzJTLJIqXHzkY x1XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 8si1199924pfm.274.2022.01.12.15.43.41; Wed, 12 Jan 2022 15:43:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355738AbiALRdu (ORCPT + 71 others); Wed, 12 Jan 2022 12:33:50 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55691 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355676AbiALRdf (ORCPT ); Wed, 12 Jan 2022 12:33:35 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7B14A20009; Wed, 12 Jan 2022 17:33:30 +0000 (UTC) From: Miquel Raynal To: Alexander Aring , Stefan Schmidt , linux-wpan@vger.kernel.org, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Michael Hennerich , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Thomas Petazzoni , linux-wireless@vger.kernel.org, Miquel Raynal Subject: [wpan-next v2 08/27] net: ieee802154: Drop symbol duration settings when the core does it already Date: Wed, 12 Jan 2022 18:32:53 +0100 Message-Id: <20220112173312.764660-9-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220112173312.764660-1-miquel.raynal@bootlin.com> References: <20220112173312.764660-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The core now knows how to set the symbol duration in a few cases, when drivers correctly advertise the protocols used on each channel. For these drivers, there is no more need to bother with symbol duration, so just drop the duplicated code. Signed-off-by: Miquel Raynal --- drivers/net/ieee802154/ca8210.c | 1 - drivers/net/ieee802154/mcr20a.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 82b2a173bdbd..d3a9e4fe05f4 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -2977,7 +2977,6 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw) ca8210_hw->phy->cca.mode = NL802154_CCA_ENERGY_CARRIER; ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND; ca8210_hw->phy->cca_ed_level = -9800; - ca8210_hw->phy->symbol_duration = 16 * 1000; ca8210_hw->phy->lifs_period = 40; ca8210_hw->phy->sifs_period = 12; ca8210_hw->flags = diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c index 8aa87e9bf92e..da2ab19cb5ee 100644 --- a/drivers/net/ieee802154/mcr20a.c +++ b/drivers/net/ieee802154/mcr20a.c @@ -975,7 +975,6 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp) dev_dbg(printdev(lp), "%s\n", __func__); - phy->symbol_duration = 16 * 1000; phy->lifs_period = 40; phy->sifs_period = 12; @@ -1010,7 +1009,6 @@ static void mcr20a_hw_setup(struct mcr20a_local *lp) phy->current_page = 0; /* MCR20A default reset value */ phy->current_channel = 20; - phy->symbol_duration = 16 * 1000; phy->supported.tx_powers = mcr20a_powers; phy->supported.tx_powers_size = ARRAY_SIZE(mcr20a_powers); phy->cca_ed_level = phy->supported.cca_ed_levels[75]; -- 2.27.0