Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <86458042c4dfcaa6aa971c9ec37f1cc77fd95cfe.camel@coelho.fi>
From:   Luca Coelho <luca@coelho.fi>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, lenb@kernel.org,
        johannes@sipsolutions.net
Date:   Thu, 13 Jan 2022 14:09:59 +0200
In-Reply-To: <87bl0fud2z.fsf@kernel.org>
References: <iwlwifi.20220113104217.0ae07c2712dc.I14e2985bfd7ddd8a8d83eb1869b800c0e7f30db4@changeid>
         <87bl0fud2z.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.2-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] iwlwifi: mvm: check if SAR GEO is supported before
 sending command
Precedence: bulk

On Thu, 2022-01-13 at 12:47 +0200, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
> 
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > Older hardware, for instance 3160, do not support SAR GEO offsets.  We
> > used to check for support before sending the command, but when moving
> > the command to the init phase, we lost the check.  This causes a
> > failure when initializing HW that do not support this command.
> > 
> > Fix that by adding a check before sending the command.  Additionally,
> > fix the caller so that it checks for the return value of the
> > iwl_mvm_sar_geo_init() function, which it was ignoring.
> > 
> > Fixes: db700bc35703 ("iwlwifi: mvm: check if SAR GEO is supported before sending command")
> 
> $ git show db700bc35703
> fatal: ambiguous argument 'db700bc35703': unknown revision or path not in the working tree.
> 
> No need to resend because of this, if you can provide the commit id I
> can fix the tag.

Oops, sorry, I added the tag to my own commit...

This is the correct one:

Fixes: 78a19d5285d9 ("iwlwifi: mvm: Read the PPAG and SAR tables at INIT stage")

--
Luca.