Message-ID: <36a7513b-2912-f46f-1a88-a07946ef703f@nbd.name>
Date:   Fri, 12 Nov 2021 12:49:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: [PATCH] mt76: testmode: add support to set MAC
Content-Language: en-US
To:     Shayne Chen <shayne.chen@mediatek.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-mediatek <linux-mediatek@lists.infradead.org>
References: <20211109040830.27536-1-shayne.chen@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20211109040830.27536-1-shayne.chen@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-11-09 05:08, Shayne Chen wrote:
> Add support to set SA/DA/BSSID in testmode.
> During mass production stage, some test scripts or test equipments need
> to set fixed addresses to detect or parse if a test is passed.
> Also, MAC setting is necessary for some tx/rx tests with rx filter,
> to make sure rx site only receives expected packets.
> 
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
>   drivers/net/wireless/mediatek/mt76/mt76.h     |  2 ++
>   drivers/net/wireless/mediatek/mt76/testmode.c | 36 +++++++++++++++++--
>   drivers/net/wireless/mediatek/mt76/testmode.h |  4 +++
>   3 files changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
> index e2da720..e7ced94 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76.h
> @@ -599,6 +599,8 @@ struct mt76_testmode_data {
>   	u8 tx_power[4];
>   	u8 tx_power_control;
>   
> +	u8 addr[3][ETH_ALEN];
> +
>   	u32 tx_pending;
>   	u32 tx_queued;
>   	u16 tx_queued_limit;
> diff --git a/drivers/net/wireless/mediatek/mt76/testmode.c b/drivers/net/wireless/mediatek/mt76/testmode.c
> index 66afc2b..74621b9 100644
> --- a/drivers/net/wireless/mediatek/mt76/testmode.c
> +++ b/drivers/net/wireless/mediatek/mt76/testmode.c
> @@ -126,9 +126,9 @@ int mt76_testmode_alloc_skb(struct mt76_phy *phy, u32 len)
>   
>   	hdr = __skb_put_zero(head, head_len);
>   	hdr->frame_control = cpu_to_le16(fc);
> -	memcpy(hdr->addr1, phy->macaddr, sizeof(phy->macaddr));
> -	memcpy(hdr->addr2, phy->macaddr, sizeof(phy->macaddr));
> -	memcpy(hdr->addr3, phy->macaddr, sizeof(phy->macaddr));
> +	ether_addr_copy(hdr->addr1, td->addr[0]);
> +	ether_addr_copy(hdr->addr2, td->addr[1]);
> +	ether_addr_copy(hdr->addr3, td->addr[2]);
ether_addr_copy assumes that source and destination are u16 aligned. I'm 
not sure that's guaranteed for td->addr.
I think you either need to stick to memcpy or make the alignment of 
td->addr explicit.

- Felix