Message-ID: <9b087a78-fb5f-40f4-378b-77ca53de3aab@nbd.name>
Date:   Fri, 12 Nov 2021 12:52:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: [PATCH v2] mt76: do not pass the received frame with decryption
 error
Content-Language: en-US
To:     Xing Song <xing.song@mediatek.com>
Cc:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
        Shayne Chen <shayne.chen@mediatek.com>,
        Ryder Lee <ryder.lee@mediatek.com>,
        Evelyn Tsai <evelyn.tsai@mediatek.com>,
        linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20211110025404.174080-1-xing.song@mediatek.com>
From:   Felix Fietkau <nbd@nbd.name>
In-Reply-To: <20211110025404.174080-1-xing.song@mediatek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-11-10 03:54, Xing Song wrote:
> Drop the received frame if decryption failed and mac80211 can not
> handle it.
> 
> Signed-off-by: Xing Song <xing.song@mediatek.com>
What happens if decryption failed? Do we receive the encrypted packets?
If so, I think we should return -EINVAL only if we don't have any 
monitor mode interfaces. If monitor mode is active, we should probably 
just clear RX_FLAG_DECRYPTED instead.

- Felix