Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35DDC433EF for ; Mon, 15 Nov 2021 09:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F15C63215 for ; Mon, 15 Nov 2021 09:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237270AbhKOJ3q (ORCPT ); Mon, 15 Nov 2021 04:29:46 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:39203 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237691AbhKOJ27 (ORCPT ); Mon, 15 Nov 2021 04:28:59 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1636968364; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=pM1Hj7+qTdm+bCFtPE48hOmFVlAu6IkxkbjG6nyb82M=; b=D206LDBN64b5PNGj2HKk3Cqgbaq9I19NJV3WTgiWOEVC3jXZ894dNpaaxzgoqYc7X3zN1Ef4 0a/sa+e8xxoH366HP9D/BhoYfHTHG18YLZ9Jwtpw1pbAnVgKIH5NzpUsWAWmmkUkrBEK5hl9 BTZnPwuqktJJQBV1LAJuhyRotjA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 619227abe10f164c25e5a80f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 15 Nov 2021 09:26:03 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 58E54C43635; Mon, 15 Nov 2021 09:26:02 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 312FEC43617; Mon, 15 Nov 2021 09:25:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 312FEC43617 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath11k: Increment pending_mgmt_tx count before tx send invoke From: Kalle Valo In-Reply-To: <1635168282-8845-1-git-send-email-quic_ppranees@quicinc.com> References: <1635168282-8845-1-git-send-email-quic_ppranees@quicinc.com> To: P Praneesh Cc: , , P Praneesh , Lavanya Suresh User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163696835789.13305.793744230126024707.kvalo@codeaurora.org> Date: Mon, 15 Nov 2021 09:26:02 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org P Praneesh wrote: > There is a race condition whereby the tx completion handler can be invoked > before the 'num_pending_mgmt_tx" count is incremented. If that occurs, we > could get warning trace indicating that 'num_pending_mgmt_tx' is 0 (because > it was not yet incremented). Ideally, this trace should be seen only if > mgmt tx has not happened but tx completion is received, and it is not > expected in this race condition. > > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01386-QCAHKSWPL_SILICONZ-1 > > Co-developed-by: Lavanya Suresh > Signed-off-by: Lavanya Suresh > Signed-off-by: P Praneesh > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c0b0d2e87d91 ath11k: Increment pending_mgmt_tx count before tx send invoke -- https://patchwork.kernel.org/project/linux-wireless/patch/1635168282-8845-1-git-send-email-quic_ppranees@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches