Sender: bqiang=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 16 Nov 2021 10:50:00 +0800
From:   Baochen Qiang <bqiang@codeaurora.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 0/7] ath11k: support one MSI vector
In-Reply-To: <878rxpiudp.fsf@codeaurora.org>
References: <20211026041616.4956-1-bqiang@codeaurora.org>
 <878rxpiudp.fsf@codeaurora.org>
Message-ID: <72c4443df7de4f6fa4b87d2244766c85@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-11-15 18:30, Kalle Valo wrote:
> Baochen Qiang <bqiang@codeaurora.org> writes:
> 
>> This patch set is to support one MSI vector for QCA6390.
>> 
>> Depends-On:
>>   1. ath11k: Fix crash caused by uninitialized TX ring
>>   
>> https://patchwork.kernel.org/project/linux-wireless/patch/20211026011605.58615-1-quic_bqiang@quicinc.com/
>> 
>> Baochen Qiang (1):
>>   ath11k: Set IRQ affinity to CPU0 in case of one MSI vector
>> 
>> Carl Huang (6):
>>   ath11k: get msi_data again after request_irq is called
>>   ath11k: add CE and ext IRQ flag to indicate irq_handler
>>   ath11k: use ATH11K_PCI_IRQ_DP_OFFSET for DP IRQ
>>   ath11k: refactor multiple MSI vector implementation
>>   ath11k: supports one MSI vector
>>   ath11k: do not restore ASPM in case of single MSI vector
> 
> I assume this is v2 of Carl's patchset:
> 
> https://patchwork.kernel.org/project/linux-wireless/cover/20201223030225.2345-1-cjhuang@codeaurora.org/
> 
> Can you provide a changelog? No need to resend because of that, just a
> reply to this thread enough.

Hi Kalle, this is the changelog:

1. changes by Kalle based on Carl's v1:

* add a log message for MSI vector count
* add a log message when disabling ASPM
* patch 1: fix error handling in ath11k_pci_probe()
* patch 1: simplify ath11k_pci_config_msi_data()
* patch 2: convert booleans to set_bit() & co for atomic access
* patch 2:__ath11k_pci_ext_irq_disable(): fix compilation
* patch 4: bool vectors_32_capability to set_bit() for atomic access
* patch 4: ath11k_mhi_get_msi(): don't use ? operator
* improve commits logs a bit

2. changes by Baochen based on Kalle's version:

* add a new patch: "ath11k: Set IRQ affinity to CPU0 in case of one MSI 
vector"
* address Jeff's comments on "ath11k: do not restore ASPM in case of 
single MSI vector":
	change debug info from "disabling PCI ASPM ..." to "leaving PCI ASPM 
disabled ..."
* change error handling in patch "ath11k: get msi_data again after 
request_irq is called"
* address Vasanth's comments on "ath11k: refactor multiple msi vector 
implementation"