Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67107C433F5 for ; Wed, 17 Nov 2021 07:33:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40FE261B54 for ; Wed, 17 Nov 2021 07:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233690AbhKQHf5 (ORCPT ); Wed, 17 Nov 2021 02:35:57 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:22869 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233408AbhKQHf5 (ORCPT ); Wed, 17 Nov 2021 02:35:57 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637134379; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=A5Oll31t88OvjOfeFNp9bH5UDfepo9hrBwl2bYIFdEs=; b=pMr12F5fxyx9z3IR09BJe1mzE567KDzGr+0boE6LoA/cb+0Ud5aRqh2b+k1B8RRy2/XgTCAf M4JBKMvAjILeqzfFtWzqhkiFkm1W1kRCM2yI9I6oxPyc4f9nYNVH+2M1bJe+GPw/WcQlAegf I5xjDLZPieQOzaglpJVyroZ4Quo= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 6194b02911cd6d407790be9f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 17 Nov 2021 07:32:57 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B12EDC43460; Wed, 17 Nov 2021 07:32:57 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 27225C4338F; Wed, 17 Nov 2021 07:32:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 27225C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/2] ath11k: clear the keys properly via DISABLE_KEY From: Kalle Valo In-Reply-To: <20211115100441.33771-1-sven@narfation.org> References: <20211115100441.33771-1-sven@narfation.org> To: Sven Eckelmann Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, Karthikeyan Kathirvel , Sven Eckelmann User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163713437291.31320.11796327341306662079.kvalo@codeaurora.org> Date: Wed, 17 Nov 2021 07:32:57 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sven Eckelmann wrote: > DISABLE_KEY sets the key_len to 0, firmware will not delete the keys if > key_len is 0. Changing from security mode to open mode will cause mcast > to be still encrypted without vdev restart. > > Set the proper key_len for DISABLE_KEY cmd to clear the keys in > firmware. > > Tested-on: IPQ6018 hw1.0 AHB WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Reported-by: Sven Eckelmann > Signed-off-by: Karthikeyan Kathirvel > [sven@narfation.org: split into separate patches, clean up commit message] > Signed-off-by: Sven Eckelmann > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 436a4e886598 ath11k: clear the keys properly via DISABLE_KEY 64bc3aa02ae7 ath11k: reset RSN/WPA present state for open BSS -- https://patchwork.kernel.org/project/linux-wireless/patch/20211115100441.33771-1-sven@narfation.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches