Sender: wgong=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 17 Nov 2021 17:35:14 +0800
From:   Wen Gong <wgong@codeaurora.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 0/3] ath11k: add feature for device recovery
In-Reply-To: <87sfvvdx1f.fsf@codeaurora.org>
References: <20211015035459.14190-1-wgong@codeaurora.org>
 <87h7cdh970.fsf@codeaurora.org>
 <a9efda4011061f2f0d57ea597b9b8f0e@codeaurora.org>
 <87sfvvdx1f.fsf@codeaurora.org>
Message-ID: <21a93f4c93e636b47bd04e75cae90461@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-11-17 16:08, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
> 
>> On 2021-11-15 20:53, Kalle Valo wrote:
>>> Wen Gong <wgong@codeaurora.org> writes:
>>> 
>>>> From: Wen Gong <quic_wgong@quicinc.com>
>>>> 
...
>>> 
>> 
>> I have sent v4, it is not to fix your fail:)
>> It added patch "ath11k: fix invalid m3 buffer address".
>> https://patchwork.kernel.org/project/linux-wireless/cover/20211116041522.23529-1-quic_wgong@quicinc.com/
>> 
>> 
>>> Also there should be a clear ath11k_warn() message when firmware
>>> recovery was successful, I could not find one from patches.
>> 
>> Yes, if recovery succes, it will have "success" log.
> 
> Where are the printouts? I cannot find any ath11k_warn() messages in 
> v4.
> Basically I would want to see something like this when the firmware
> crashes:

It is not print in this patch.
It is here:

ath11k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
				enum ieee80211_reconfig_type reconfig_type)
	if (ar->state == ATH11K_STATE_RESTARTED) {
		ath11k_warn(ar->ab, "pdev %d successfully recovered\n",
			    ar->pdev->pdev_id);

> 
> firmware crashed, restarting it
> 
> And once the firmware is running again:
> 
> firmware restarted succesfully

"firmware crashed" log is here:
static void ath11k_mhi_op_status_cb(struct mhi_controller *mhi_cntrl,
				    enum mhi_callback cb)
{
	struct ath11k_base *ab = dev_get_drvdata(mhi_cntrl->cntrl_dev);
	struct ath11k_pci *ar_pci = ath11k_pci_priv(ab);

	switch (cb) {
	case MHI_CB_SYS_ERROR:
		ath11k_warn(ab, "firmware crashed: MHI_CB_SYS_ERROR\n");