Subject: Re: [PATCH 1/8] mt76: mt7915: cache sgi in wcid.
To:     Ryder Lee <ryder.lee@mediatek.com>, linux-wireless@vger.kernel.org
References: <20211118164549.3863-1-greearb@candelatech.com>
 <c0a09707cf9bcf1205b60c7a36e5afa2a6b2f39c.camel@mediatek.com>
From:   Ben Greear <greearb@candelatech.com>
Organization: Candela Technologies
Message-ID: <7ec78991-2104-a3f7-dd2f-373cf6a10019@candelatech.com>
Date:   Thu, 18 Nov 2021 09:10:42 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <c0a09707cf9bcf1205b60c7a36e5afa2a6b2f39c.camel@mediatek.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/18/21 9:06 AM, Ryder Lee wrote:
> On Thu, 2021-11-18 at 08:45 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> Explicitly cache short_gi and he_gi in wcid, don't try to store
>> it in the wcid.rate object.  Slightly less confusing and less fragile
>> when TXS starts parsing lots of frames.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>
>> This is actually the first series, not that one I posted a few
>> minutes
>> ago.  txs, tx overrides and other things.  Rebased on top of 5.16

> 
> Maybe we can consider switching to use existing fixed-rate method in
> debugfs? On th other hand, that's the only way to configure HE MU UL
> fixed-rate.

This patch is to improve reported tx rates, not to control tx rates.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com