Message-ID: <9251a91c3bf2ca37e86fb3eb67c6c57ba90ddf2b.camel@mediatek.com>
Subject: Re: [PATCH 1/8] mt76: mt7915: cache sgi in wcid.
From:   Ryder Lee <ryder.lee@mediatek.com>
To:     Ben Greear <greearb@candelatech.com>,
        <linux-wireless@vger.kernel.org>
Date:   Fri, 19 Nov 2021 01:20:49 +0800
In-Reply-To: <7ec78991-2104-a3f7-dd2f-373cf6a10019@candelatech.com>
References: <20211118164549.3863-1-greearb@candelatech.com>
         <c0a09707cf9bcf1205b60c7a36e5afa2a6b2f39c.camel@mediatek.com>
         <7ec78991-2104-a3f7-dd2f-373cf6a10019@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

 * On Thu, 2021-11-18 at 09:10 -0800, Ben Greear wrote:
> On 11/18/21 9:06 AM, Ryder Lee wrote:
> > On Thu, 2021-11-18 at 08:45 -0800, greearb@candelatech.com wrote:
> > > From: Ben Greear <greearb@candelatech.com>
> > > 
> > > Explicitly cache short_gi and he_gi in wcid, don't try to store
> > > it in the wcid.rate object.  Slightly less confusing and less
> > > fragile
> > > when TXS starts parsing lots of frames.
> > > 
> > > Signed-off-by: Ben Greear <greearb@candelatech.com>
> > > ---
> > > 
> > > This is actually the first series, not that one I posted a few
> > > minutes
> > > ago.  txs, tx overrides and other things.  Rebased on top of 5.16
> > 
> > Maybe we can consider switching to use existing fixed-rate method
> > in
> > debugfs? On th other hand, that's the only way to configure HE MU
> > UL
> > fixed-rate.
> 
> This patch is to improve reported tx rates, not to control tx rates.
> 

Ah.  I shall reply [PATCH 8/8] mt76: mt7915: fix SGI reporting when
using tx-overrides.