Date:   Mon, 22 Nov 2021 11:58:38 +0100
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Lorenzo Bianconi <lorenzo@kernel.org>,
        linux-wireless@vger.kernel.org, cjhuang@codeaurora.org
Subject: Re: [PATCH mac80211] cfg80211: check nla_parse_nested return code in
 nl80211_set_sar_specs
Message-ID: <YZt33qMzxkxSAAxY@lore-desk>
References: <3b6fee130e2d264242463cff063bcfb6d6f5da83.1637494779.git.lorenzo@kernel.org>
 <a54298c0b747ba562caa47f271f058b9831810ee.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="fxByCKSwajzW4WMX"
Content-Disposition: inline
In-Reply-To: <a54298c0b747ba562caa47f271f058b9831810ee.camel@sipsolutions.net>
Precedence: bulk


--fxByCKSwajzW4WMX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Sun, 2021-11-21 at 12:41 +0100, Lorenzo Bianconi wrote:
> > Check error code returned by nla_parse_nested in nl80211_set_sar_specs
> > routine before parsing SAR sub-specs.
> >=20
>=20
> I don't think we need to. The policy already states it:
>=20
>         [NL80211_ATTR_SAR_SPEC] =3D NLA_POLICY_NESTED(sar_policy),

ack, right, I missed that. I guess we can drop the patch.

Regards,
Lorenzo

>=20
>=20
> Since we always parse the top-level already in the generic netlink code,
> it will recurse down here by way of that policy link, and then it will
> already be validated as much as nla_parse_nested() can do again - so we
> only do it again here to actually get access to the pointers.
>=20
> johannes
>=20

--fxByCKSwajzW4WMX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYZt33gAKCRA6cBh0uS2t
rMicAP4iCS0Y4hxL6H396MSMyOcxY6Xx4etmrZ1L23l0pMUxSQD9GhzWCHpgPxqZ
RwJ3ZB/HXTzmSdijjVC7g94wukGGsQ0=
=Kc3Z
-----END PGP SIGNATURE-----

--fxByCKSwajzW4WMX--