Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC6EC433EF for ; Mon, 22 Nov 2021 14:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239731AbhKVOhG (ORCPT ); Mon, 22 Nov 2021 09:37:06 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:60915 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239725AbhKVOhG (ORCPT ); Mon, 22 Nov 2021 09:37:06 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637591639; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=OjrTvaa4H5Vb77OrB7p/bDCGP1Zzm2JWWr31uxP5SKk=; b=LmJ8UvT3GCPgQy/eUkbV05BV60TNaM/2H8rhFoXoKcNXwWJPOEGYp5fMHMjYkRrMylKs6jzX JPYFgmcbyAhjGU/wSqpfRXTwnT68N3Zp4ILI8VZps3i9Gd+3c42dNsD3YwKM4dHprwg4BhWq A4HWmF3slGHqIPydRrZpb1pu0wU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 619baa56db3ac5552ac17283 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Nov 2021 14:33:58 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BBB3CC4360C; Mon, 22 Nov 2021 14:33:58 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3EDD1C4338F; Mon, 22 Nov 2021 14:33:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 3EDD1C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath11k: fix read fail for htt_stats and htt_peer_stats for single pdev From: Kalle Valo In-Reply-To: <20211118095700.8149-1-quic_wgong@quicinc.com> References: <20211118095700.8149-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163759163508.17469.1762707859387568333.kvalo@codeaurora.org> Date: Mon, 22 Nov 2021 14:33:58 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > The pdev id is set to 0 for single pdev configured hardware, the real > pdev id is not 0 in firmware, for example, its pdev id is 1 for 5G/6G > phy and 2 for 2G band phy. For HTT_H2T_MSG_TYPE_EXT_STATS_CFG message, > firmware parse the pdev_mask to its pdev id, ath11k set it to 0 for > single pdev, it is not correct, need set it with the real pdev id of > firmware. > > Save the real pdev id report by firmware and set it correctly. > > Below commands run success with this patch: > cat /sys/kernel/debug/ieee80211/phy0/ath11k/htt_stats > cat /sys/kernel/debug/ieee80211/phy0/netdev\:wls1/stations/00\:03\:7f\:75\:59\:85/htt_peer_stats > > Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1370634054d4 ath11k: fix read fail for htt_stats and htt_peer_stats for single pdev -- https://patchwork.kernel.org/project/linux-wireless/patch/20211118095700.8149-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches