Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269F4C433F5 for ; Mon, 22 Nov 2021 14:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239744AbhKVOhm (ORCPT ); Mon, 22 Nov 2021 09:37:42 -0500 Received: from so254-9.mailgun.net ([198.61.254.9]:44720 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239644AbhKVOhl (ORCPT ); Mon, 22 Nov 2021 09:37:41 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637591675; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=WNBSXVQoNFNhvohQ98lEnNls0MW3PeFjax9xKqQgbno=; b=iPGDHb7mm9pRISdI1nhAEA4xr0eHXdwPS6vv0R2FBUH7SO/9HLkM73y6+owAewzm3hnDw7yr GLnzpUDux0pi1BoULrNeV0onI8QIWdGFdLM7FG1XIFk8YhhN3Argn/Fnl6TnfrWOenb1zGmo uLNNDXDGOG4/hPE7dKf9zpRn7CQ= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 619baa7a2c7dc0a764427a7b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Nov 2021 14:34:34 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5723DC43618; Mon, 22 Nov 2021 14:34:34 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A830BC4360D; Mon, 22 Nov 2021 14:34:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A830BC4360D Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath11k: skip sending vdev down for channel switch From: Kalle Valo In-Reply-To: <20211118095901.8271-1-quic_wgong@quicinc.com> References: <20211118095901.8271-1-quic_wgong@quicinc.com> To: Wen Gong Cc: , , User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163759167100.17469.7976011024924316593.kvalo@codeaurora.org> Date: Mon, 22 Nov 2021 14:34:34 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > The ath11k driver currently sends vdev down to the firmware before > updating the channel context, which is followed by a vdev restart > command. > > Sending vdev down is not required before sending a vdev restart, > because the firmware internally does vdev down when ath11k sends > a vdev restart command. > > Firmware will happen crash while channel switch without this change. > > Hence skip the vdev down command sending when updating the channel > context and then fix the firmware crash issue. > > Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a4146249a333 ath11k: skip sending vdev down for channel switch -- https://patchwork.kernel.org/project/linux-wireless/patch/20211118095901.8271-1-quic_wgong@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches