Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download
 board data
To:     Kalle Valo <kvalo@codeaurora.org>,
        Wen Gong <quic_wgong@quicinc.com>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
References: <20211118100033.8384-1-quic_wgong@quicinc.com>
 <163759171706.17469.3004620526954131593.kvalo@codeaurora.org>
From:   Mark Herbert <mark.herbert42@gmail.com>
Message-ID: <f237c04d-6574-ec9a-ebca-65d2d9ff9edd@gmail.com>
Date:   Mon, 22 Nov 2021 20:58:56 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <163759171706.17469.3004620526954131593.kvalo@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Tried this on Dell XPS 13 9310

Maybe this patch is good for 6855, but 6390 in Dell seems to be killed 
completely with it. Reverting it makes things work again.

[    5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_family 0xb 
board_id 0xff soc_id 0xffffffff
[    5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c06cc 
fw_build_timestamp 2020-06-24 19:50 fw_build_id
[    5.537236] ath11k_pci 0000:72:00.0: failed to fetch board data for 
bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=DE_1901 from 
ath11k/QCA6390/hw2.0/board-2.bin
[    5.537255] ath11k_pci 0000:72:00.0: failed to fetch board-2.bin or 
board.bin from QCA6390/hw2.0
[    5.537257] ath11k_pci 0000:72:00.0: qmi failed to fetch board file: -2
[    5.537258] ath11k_pci 0000:72:00.0: failed to load board data file: -2

On 22.11.2021 17:35, Kalle Valo wrote:
> Wen Gong <quic_wgong@quicinc.com> wrote:
>
>> This is to read variant from SMBIOS such as read from DT, the variant
>> string will be used to one part of string which used to search board
>> data from board-2.bin.
>>
>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>>
>> Signed-off-by: Wen Gong <quic_wgong@quicinc.com>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Patch applied to ath-next branch of ath.git, thanks.
>
> 46e46db313a2 ath11k: add read variant from SMBIOS for download board data
>