Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 3D657C4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Mark Herbert <mark.herbert42@gmail.com>
Cc:     Wen Gong <quic_wgong@quicinc.com>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath11k: add read variant from SMBIOS for download board data
References: <20211118100033.8384-1-quic_wgong@quicinc.com>
        <163759171706.17469.3004620526954131593.kvalo@codeaurora.org>
        <f237c04d-6574-ec9a-ebca-65d2d9ff9edd@gmail.com>
Date:   Mon, 22 Nov 2021 20:06:22 +0200
In-Reply-To: <f237c04d-6574-ec9a-ebca-65d2d9ff9edd@gmail.com> (Mark Herbert's
        message of "Mon, 22 Nov 2021 20:58:56 +0300")
Message-ID: <871r3883q9.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Mark Herbert <mark.herbert42@gmail.com> writes:

> Tried this on Dell XPS 13 9310
>
> Maybe this patch is good for 6855, but 6390 in Dell seems to be killed
> completely with it. Reverting it makes things work again.
>
> [=C2=A0=C2=A0=C2=A0 5.537034] ath11k_pci 0000:72:00.0: chip_id 0x0 chip_f=
amily 0xb
> board_id 0xff soc_id 0xffffffff
> [=C2=A0=C2=A0=C2=A0 5.537038] ath11k_pci 0000:72:00.0: fw_version 0x101c0=
6cc
> fw_build_timestamp 2020-06-24 19:50 fw_build_id
> [=C2=A0=C2=A0=C2=A0 5.537236] ath11k_pci 0000:72:00.0: failed to fetch bo=
ard data for
> bus=3Dpci,qmi-chip-id=3D0,qmi-board-id=3D255,variant=3DDE_1901 from
> ath11k/QCA6390/hw2.0/board-2.bin
> [=C2=A0=C2=A0=C2=A0 5.537255] ath11k_pci 0000:72:00.0: failed to fetch bo=
ard-2.bin or
> board.bin from QCA6390/hw2.0
> [=C2=A0=C2=A0=C2=A0 5.537257] ath11k_pci 0000:72:00.0: qmi failed to fetc=
h board file: -2
> [=C2=A0=C2=A0=C2=A0 5.537258] ath11k_pci 0000:72:00.0: failed to load boa=
rd data file: -2

Doh, I didn't realise that. I only tested this on my NUC testbox, I
should have tested this on my XPS 13 9310 as well. Thanks for the
report!

I think I need to revert this and rethink how to handle the backwards
compatibility.

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes