Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30A6C433EF for ; Mon, 22 Nov 2021 18:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240326AbhKVSdY (ORCPT ); Mon, 22 Nov 2021 13:33:24 -0500 Received: from m43-7.mailgun.net ([69.72.43.7]:15127 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231756AbhKVSdV (ORCPT ); Mon, 22 Nov 2021 13:33:21 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637605815; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=hS+cNZNvsc18vNvR+2V+IqRLIQR1if5Mbok+6txtYhw=; b=S0tsdtys/x9Euidznm4XUqIoahFfz4TURcA4PpVCu18uKAaeXQ4ByK7bFPsviLXcnPFs3087 rPVsRwbLmb0ECmpPHHEaSZGRyublPmDCFauCSGuMBBZLZ0Mdnna1DzFeQfukKtCEA4EuImss o5kbA+XRYW1JRncuolSlQovZ940= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 619be1b386d0e4d888b796be (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Nov 2021 18:30:11 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2723EC4360C; Mon, 22 Nov 2021 18:30:10 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D6910C4360C; Mon, 22 Nov 2021 18:30:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org D6910C4360C Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] [v2] iwlwifi: pcie: fix constant-conversion warning From: Kalle Valo In-Reply-To: <20211111073145.2504032-1-arnd@kernel.org> References: <20211111073145.2504032-1-arnd@kernel.org> To: Arnd Bergmann Cc: Luca Coelho , "David S. Miller" , Jakub Kicinski , Nathan Chancellor , Nick Desaulniers , Johannes Berg , Arnd Bergmann , kernel test robot , Yaara Baruch , Matti Gottlieb , Emmanuel Grumbach , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163760580216.5904.8642934154284226912.kvalo@codeaurora.org> Date: Mon, 22 Nov 2021 18:30:10 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out a potential issue with integer overflow when > the iwl_dev_info_table[] array is empty: > > drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion] > for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) { > ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > > This is still harmless, as the loop correctly terminates, but adding > an extra range check makes that obvious to both readers and to the > compiler. > > Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()") > Reported-by: kernel test robot > Cc: Nick Desaulniers > Signed-off-by: Arnd Bergmann > Acked-by: Luca Coelho Dropping v2 and taking v3 instead. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20211111073145.2504032-1-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches