Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 875B8C4338F
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH v1] iwlwifi: fix warnings produced by kernel debug options
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20211110215744.5487-1-lukasz.bartosik@semihalf.com>
References: <20211110215744.5487-1-lukasz.bartosik@semihalf.com>
To:     Lukasz Bartosik <lb@semihalf.com>
Cc:     Luca Coelho <luciano.coelho@intel.com>,
        linux-wireless@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>, upstream@semihalf.com
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <163760633056.7371.9090879502801435579.kvalo@codeaurora.org>
Date:   Mon, 22 Nov 2021 18:38:54 +0000 (UTC)
Precedence: bulk

Lukasz Bartosik <lb@semihalf.com> wrote:

> From: Łukasz Bartosik <lb@semihalf.com>
> 
> Fix warnings produced by:
> - lockdep_assert_wiphy() in function reg_process_self_managed_hint(),
> - wiphy_dereference() in function iwl_mvm_init_fw_regd().
> Both function are expected to be called in critical section.
> 
> The warnings were discovered when running v5.15 kernel
> with debug options enabled:
> 
> 1)
> Hardware name: Google Delbin/Delbin
> RIP: 0010:reg_process_self_managed_hint+0x254/0x347 [cfg80211]
> ...
> Call Trace:
> regulatory_set_wiphy_regd_sync+0x3d/0xb0
> iwl_mvm_init_mcc+0x49d/0x5a2
> iwl_op_mode_mvm_start+0x1b58/0x2507
> ? iwl_mvm_reprobe_wk+0x94/0x94
> _iwl_op_mode_start+0x146/0x1a3
> iwl_opmode_register+0xda/0x13d
> init_module+0x28/0x1000
> 
> 2)
> drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:263 suspicious rcu_dereference_protected() usage!
> ...
> Hardware name: Google Delbin/Delbin, BIOS Google_Delbin
> Call Trace:
> dump_stack_lvl+0xb1/0xe6
> iwl_mvm_init_fw_regd+0x2e7/0x379
> iwl_mvm_init_mcc+0x2c6/0x5a2
> iwl_op_mode_mvm_start+0x1b58/0x2507
> ? iwl_mvm_reprobe_wk+0x94/0x94
> _iwl_op_mode_start+0x146/0x1a3
> iwl_opmode_register+0xda/0x13d
> init_module+0x28/0x100
> 
> Fixes: a05829a7222e ("cfg80211: avoid holding the RTNL when calling the driver")
> Signed-off-by: Łukasz Bartosik <lb@semihalf.com>

Patch applied to wireless-drivers.git, thanks.

f5cecf1d4c5f iwlwifi: fix warnings produced by kernel debug options

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211110215744.5487-1-lukasz.bartosik@semihalf.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches