Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CC8C433EF for ; Mon, 22 Nov 2021 18:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239641AbhKVSmT (ORCPT ); Mon, 22 Nov 2021 13:42:19 -0500 Received: from so254-9.mailgun.net ([198.61.254.9]:12316 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231714AbhKVSmS (ORCPT ); Mon, 22 Nov 2021 13:42:18 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637606339; h=Date: Message-ID: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=0eiMpL92qixT6eiIh39EiAsB/yyVIDh32LJQjrhTesE=; b=MmNAj2PmYEwkLFPFYZHUK//ubUB+oP+++BYMtmmID1NeoRV8TQ8qZ+THEO7j+FmbX1G1IXE0 e9NHftuABsQibvX8JnhC3phPwuxE6JjJL2fkchVtENnw45R1Ds26Rk2NfQR41p2zgNTR+JLi 6xWWba2V5wxDODYG6CoIfZYzsDI= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 619be3a42c7dc0a764e7a78f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Nov 2021 18:38:28 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 90491C4360C; Mon, 22 Nov 2021 18:38:28 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 55FB3C4338F; Mon, 22 Nov 2021 18:38:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 55FB3C4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] iwlwifi: mvm: retry init flow if failed From: Kalle Valo In-Reply-To: References: To: Luca Coelho Cc: luca@coelho.fi, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <163760630539.7371.2987004138623048649.kvalo@codeaurora.org> Date: Mon, 22 Nov 2021 18:38:28 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Luca Coelho wrote: > From: Mordechay Goodstein > > In some very rare cases the init flow may fail. In many cases, this is > recoverable, so we can retry. Implement a loop to retry two more times > after the first attempt failed. > > This can happen in two different situations, namely during probe and > during mac80211 start. For the first case, a simple loop is enough. > For the second case, we need to add a flag to prevent mac80211 from > trying to restart it as well, leaving full control with the driver. > > Cc: > Signed-off-by: Mordechay Goodstein > Signed-off-by: Luca Coelho Patch applied to wireless-drivers.git, thanks. 5283dd677e52 iwlwifi: mvm: retry init flow if failed -- https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20211110150132.57514296ecab.I52a0411774b700bdc7dedb124d8b59bf99456eb2@changeid/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches