MIME-Version: 1.0
References: <CAA=hcWT_dmKU1Uj4YmJ_rxZ+HsCVOEYJLSH-h3B3qqNhC1xi-g@mail.gmail.com>
 <CAD=FV=V3n95DNXFd4mHpkAAKapCs5UWZXUkw=1vWpfn6oXfouA@mail.gmail.com> <CAA=hcWS91uL4kRK8r1uJ_2YLXi1ZuB067ACVPTDZKnF53jgrRQ@mail.gmail.com>
In-Reply-To: <CAA=hcWS91uL4kRK8r1uJ_2YLXi1ZuB067ACVPTDZKnF53jgrRQ@mail.gmail.com>
From:   Jupiter <jupiter.hce@gmail.com>
Date:   Tue, 23 Nov 2021 15:38:45 +1100
Message-ID: <CAA=hcWR+9rsoy-dCnpai+fw_+JcO6X6oMBNPHJGqpuRy8mJszw@mail.gmail.com>
Subject: Re: mwifiex reset buggy
To:     Doug Anderson <dianders@chromium.org>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        Ganapathi Bhat <ganapathi.bhat@nxp.com>,
        Brian Norris <briannorris@chromium.org>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
        Linux MMC List <linux-mmc@vger.kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Doug,

I have updated the kernel to 5.10.59 which should be guaranteed to
include your reset patch.

But I could not connect to the WiFi.

#  ifconfig mlan0 up
[10262.988302] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (1) failed: -110
[10262.996049] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10263.007337] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (2) failed: -110
[10263.015299] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10263.021675] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (3) failed: -110
[10263.029839] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10263.035386] mwifiex_sdio mmc0:0001:1: DNLD_CMD: host to card failed

# echo 1 > /sys/kernel/debug/mwifiex/mlan0/reset
[10517.451193] mwifiex_sdio mmc0:0001:1: Resetting per request
[10517.479235] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (1) failed: -110
[10517.490283] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10517.498995] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (2) failed: -110
[10517.509257] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10517.517649] mwifiex_sdio mmc0:0001:1: host_to_card, write iomem
 (3) failed: -110
[10517.527838] mwifiex_sdio mmc0:0001:1: write CFG reg failed
[10517.533765] mwifiex_sdio mmc0:0001:1: DNLD_CMD: host to card failed

[10529.871099] mwifiex_sdio mmc0:0001:1: cmd_wait_q terminated: -110
[10529.883401] mwifiex_sdio mmc0:0001:1: PREP_CMD: FW in reset state
[10529.890488] mwifiex_sdio mmc0:0001:1: deleting the crypto keys
[10529.896573] mwifiex_sdio mmc0:0001:1: PREP_CMD: FW in reset state
[10529.903316] mwifiex_sdio mmc0:0001:1: deleting the crypto keys

[10530.014334] mwifiex_sdio mmc0:0001:1: DNLD_CMD: host to card failed
[10530.049847] mwifiex_sdio mmc0:0001:1: info: shutdown mwifiex...
[10530.239910] mwifiex_sdio mmc0:0001:1: PREP_CMD: card is removed
[10530.247919] mwifiex_sdio mmc0:0001:1: PREP_CMD: card is removed
[10530.268721] mwifiex_sdio mmc0:0001:1: PREP_CMD: card is removed
[10531.665962] mwifiex_sdio mmc0:0001:1: info: FW download over, size
255988 bytes
[10531.911608] mwifiex_sdio mmc0:0001:1: WLAN FW is active
[10531.964352] mwifiex_sdio mmc0:0001:1: CMD_RESP: cmd 0x242 error, result=0x2
[10531.971894] mwifiex_sdio mmc0:0001:1: mwifiex_process_cmdresp: cmd
0x242 failed during       initialization
[10532.125947] mwifiex_sdio mmc0:0001:1: info: MWIFIEX VERSION:
mwifiex 1.0 (14.68.36.p204)
[10532.134573] mwifiex_sdio mmc0:0001:1: driver_version = mwifiex 1.0
(14.68.36.p204)

Again, the /sys/kernel/debug/mwifiex/mlan0 is removed, it is
completely broken for both WiFi modem reset and
/sys/kernel/debug/mwifiex/mlan0/reset, let me know your advice to
debug it or modify mwifiex source files.

Thank you.

Kind regards,

- JH

On 11/20/21, Jupiter <jupiter.hce@gmail.com> wrote:
> Hi Doug,
>
> Thank you for your kindly response.
>
>> I think I blocked most of this stuff out of my mind and it's also been
>> over 2 years. ;-) ...but any chance that Bluetooth could somehow be
>> involved, too? I seem to remember that things got complicated because
>> we could have both functions going at once. I think I advocated for
>> keeping it simple and always doing a full unplug / replug of the card
>> to reset it, but from notes I guess upstream landed it so you need to
>> handle the two cases (just WiFi vs WiFi+BT) in totally different ways.
>
> I think the main issue is many of you tested the mwifiex reset on
> Marvell card (or BT?), unfortunately I am using uBlox Lily module
> which is a WiFi only no Bluetooth, it is a iMX6ULL custom design, MMC
> and SDIO are based on iMX6ULL EVK. I don't think anyone tested mwifiex
> reset on that card, to make it worse, I am new to mwifiex, I might be
> able to assist with debugging, but certainly not in the position to
> contribute to fixing it.
>
>> It looks like there's ongoing discussion going on in
>> https://issuetracker.google.com/172214846. Maybe something there would
>> be helpful?
>
> I am using mwifiex on kernel upstream v4.19.75, does that include your
> fix? Do you have a patch I can add to my Yocto build? Should I make
> comments to the discussion at
> https://issuetracker.google.com/172214846?
>
> Thank you very much Doug.
>
> - JH
>


--
"A man can fail many times, but he isn't a failure until he begins to
blame somebody else."
-- John Burroughs