Sender: akolli=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 23 Nov 2021 16:09:21 +0530
From:   Anilkumar Kolli <akolli@codeaurora.org>
To:     Sven Eckelmann <sven@narfation.org>
Cc:     ath11k@lists.infradead.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
        robh@kernel.org
Subject: Re: [PATCH v4 2/2] ath11k: Use reserved host DDR addresses from DT
 for PCI devices
In-Reply-To: <2802525.9g7TWp2vRq@ripper>
References: <1637504521-30997-1-git-send-email-akolli@codeaurora.org>
 <1724585.GBsqGgcNsD@sven-l14>
 <a6f4fd77b1f8729368fee13a435fe652@codeaurora.org>
 <2802525.9g7TWp2vRq@ripper>
Message-ID: <69b243375da1358f39955186fb69a55d@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-11-22 13:20, Sven Eckelmann wrote:
> On Monday, 22 November 2021 07:12:27 CET Anilkumar Kolli wrote:
> [...]
>> >> +			start = reg[0] + reg[1];
>> >> +			size = reg[2] + reg[3];
>> >
>> > See my messages for v2 [1] and v3 [2]
>> >
>> >
>> Thanks for the review,
>> 
>> Here addresses are always within 32-bit.
>> so I will change the API to read only 2 integers and update start
>> addresss and size.
> 
> The size of address and size depends on the reserved-memory node - not 
> the
> qcn9074 node. So please don't make such assumptions in your code.
> 

Yes, correct.

of_address_to_resource() returns start/end address properly.
I will update and send next version.

- Anil.