Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 56540C4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Wen Gong <quic_wgong@quicinc.com>
Cc:     P Praneesh <ppranees@codeaurora.org>, <ath11k@lists.infradead.org>,
        <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>,
        "Karthikeyan Periyasamy" <periyasa@codeaurora.org>
Subject: Re: [PATCH v3 2/3] ath11k: Refactor update channel list function
References: <1634906227-22028-1-git-send-email-ppranees@codeaurora.org>
        <1634906227-22028-3-git-send-email-ppranees@codeaurora.org>
        <0fb4fec3-4fd0-6e92-b1d9-5bffc0958e97@quicinc.com>
        <87pmqq6lyx.fsf@codeaurora.org>
        <5929130a-7824-acd1-0182-da8fa304c576@quicinc.com>
Date:   Wed, 24 Nov 2021 09:56:08 +0200
In-Reply-To: <5929130a-7824-acd1-0182-da8fa304c576@quicinc.com> (Wen Gong's
        message of "Wed, 24 Nov 2021 15:48:03 +0800")
Message-ID: <87ee766l7r.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Wen Gong <quic_wgong@quicinc.com> writes:

> On 11/24/2021 3:39 PM, Kalle Valo wrote:
>> Wen Gong <quic_wgong@quicinc.com> writes:
>>
>>> On 10/22/2021 8:37 PM, P Praneesh wrote:
>>>
>>> ...
>>>
>>>> ---
>>>> ...
>>>> -			ch->maxpower = channel->max_power * 2;
>>>> -			ch->maxregpower = channel->max_reg_power * 2;
>>>> -			ch->antennamax = channel->max_antenna_gain * 2;
>>>> ...
>>>>    +int ath11k_wmi_update_scan_chan_list(struct ath11k *ar,
>>>> +				     struct scan_req_params *arg)
>>>> ...
>>>> +			ch->maxpower = channel->max_power;
>>>> +			ch->maxregpower = channel->max_reg_power;
>>>> +			ch->antennamax = channel->max_antenna_gain;
>>>> +
>>>> ...
>>> I see it also have another patch to remove the "*2" for power.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=9212c1b9e80a869e732769a4fe7f82d392b219be
>>>
>>> ath11k: send proper txpower and maxregpower values to firmware.
>>>
>>> so are you the same reason to remove "*2" ?
>> I'm not quite getting what you are saying, can you elaborate more? Did
>> this patch break something?
>
> Oh. Not see break anything.
>
> I just want to know why remove the "*2". Did you see any issue if NOT
> remove "*2"?

All I know is that commit 9212c1b9e80a ("ath11k: send proper txpower and
maxregpower values to firmware") mentions about cca getting stuck:

ath11k: send proper txpower and maxregpower values to firmware

Set proper values for max_regpower, max_power, max_antenna_gain as it
is because firmware will convert power values to 0.5dbm steps by
multiplying it with 2.

If txpower is not set, it will lead to cca stuck resulting in latency
issues for QCN9074.

Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01386-QCAHKSWPL_SILICONZ-1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches