Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 0F46DC4338F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Adam Borowski <kilobyte@angband.pl>
Cc:     Luca Coelho <luciano.coelho@intel.com>,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: pcie: fix a warning / build failure
References: <20211124011754.22397-1-kilobyte@angband.pl>
Date:   Wed, 24 Nov 2021 10:12:35 +0200
In-Reply-To: <20211124011754.22397-1-kilobyte@angband.pl> (Adam Borowski's
        message of "Wed, 24 Nov 2021 02:17:54 +0100")
Message-ID: <87wnky55vw.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Adam Borowski <kilobyte@angband.pl> writes:

> drivers/net/wireless/intel/iwlwifi/pcie/drv.c:
>         In function =E2=80=98iwl_pci_find_dev_info=E2=80=99:
> ./include/linux/kernel.h:46:25: error: overflow in conversion from
>         =E2=80=98long unsigned int=E2=80=99 to =E2=80=98int=E2=80=99 chan=
ges value from
>         =E2=80=9818446744073709551615=E2=80=99 to =E2=80=98-1=E2=80=99 [-=
Werror=3Doverflow]
>
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
> Another option would be to #ifdef away iwl_pci_find_dev_info().
>
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/=
wireless/intel/iwlwifi/pcie/drv.c
> index c574f041f096..81e8f2fc4982 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1341,7 +1341,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_dev=
ice,
>  {
>  	int i;
>=20=20
> -	for (i =3D ARRAY_SIZE(iwl_dev_info_table) - 1; i >=3D 0; i--) {
> +	for (i =3D (int)ARRAY_SIZE(iwl_dev_info_table) - 1; i >=3D 0; i--) {
>  		const struct iwl_dev_info *dev_info =3D &iwl_dev_info_table[i];
>=20=20
>  		if (dev_info->device !=3D (u16)IWL_CFG_ANY &&

There's already fix for this:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/=
commit/?id=3Dfe785f56ad5886c08d1cadd9e8b4e1ff6a1866f6

--=20
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes